Closed Bug 170707 Opened 23 years ago Closed 23 years ago

Can't type some russian capitals and some language specific letters

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.2beta

People

(Reporter: alexander.v.rabtchevich, Assigned: tetsuroy)

References

Details

(Keywords: intl, regression)

Attachments

(1 file, 1 obsolete file)

Better patch
632 bytes, patch
shanjian
: review+
kinmoz
: superreview+
asa
: approval+
Details | Diff | Splinter Review
It is impossible to type capital Russian letters in the night build from 24.09. It is impossible both in URL field or in form fields. I remember I saw it sometimes before.
to intl.
Assignee: asa → yokoyama
Component: Browser-General → Internationalization
QA Contact: asa → ruixu
alexander: thanks for the report. marina: can you confirm this?
Target Milestone: --- → mozilla1.2beta
i just tried 2002-09-24-08 build and i was ablt to input capital russian letters in Composer and AIM. Alexander , are we using the same build? What are the fields that you are inputting the chars? Thanks.
Keywords: intl
just tried again with 2002-08-26-08 build, input capital cyrillic letters in URL and forms without a problem. Alexander, do you still see the bug?
I see the problem. But not all capitals... Cant't type capitals of: é ê å í ã ç â à ï î ë ä æ ì è á ¸ <- cyrrilic symbols marking 171261 as dupe of this one? PS I'm under WinXP and build 2002092708 (20020920 was fine).
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 171261 has been marked as a duplicate of this bug. ***
i see it also now, it is skipping some capital letters,same problem with other languages like Czech for example. It looks like it started to happen after the unicode fix was checked in. Seems that 171208 is going to be a dup.
Please, don't dup bug 171208 against this one. Rather the other way, because bug 17208 is already accepted by author of the Unicode bug 104934 which is the probable cause of the underlying problem.
OK, they are both assigned, but I would leave both open because of that. Also: correction of the Unicode bug number. It is bug 104934.
Keywords: nsbeta1, regression
*** Bug 171208 has been marked as a duplicate of this bug. ***
Why shouldn't we dup bug 171208? I do not understand the reason... It's the same problem.
Summary: Capital Russian letters are impossible to be typed → Can't type some russian capitals and some language specific letters
The patch from bug 104934 has been backed out. So this should be WFM in the latest builds. Please try them.
I've just tested this bug and bug 171208 towards it. Russian (cyrillic) capital letters still do not work. Polish letters (bug 171208) WFM ! It seems the bugs were really different, in the first place. I'm going to un-dupe 171208 and mark it as fixed.
Russian is WFM after unicode was backed out. Try to delete mozilla directory and install again. Test: ижсйемцьыгузтшбюопнкдфщъвялхрэач╗ All 33 letter is present.
OK. You're right. Installing yesterday build in a new directory made the trick (on Win2000). Marking WORKSFORME (as no patch was checked in for this bug this isn't a case for FIXED, is it?)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
Mark as verified according to comments above.
Status: RESOLVED → VERIFIED
We will try to put 104934 back in. reopening. Patch to follow.
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
shanjian: can you review?
Comment on attachment 102385 [details] [diff] [review] need to call MapVirtualKeyW() and call OnChar(.., virtualKeyCode..) looks fine. r=shanjian
Attachment #102385 - Flags: review+
kin: can you super review?
Comment on attachment 102385 [details] [diff] [review] need to call MapVirtualKeyW() and call OnChar(.., virtualKeyCode..) sr=kin@netscape.com
Attachment #102385 - Flags: superreview+
Attached patch Better patch — — Splinter Review
I found that the previous patch breaks the Cut/Paste. There are bunch of codes like uniChar = virtualKeyCode - 1 + 'A' ; which surprises me but still works. This bug can be fixed by examining the CharCode, not VirtualKeyCode. shanjian: can you review?
Attachment #102385 - Attachment is obsolete: true
QA Contact: ruixu → ylong
Comment on attachment 102401 [details] [diff] [review] Better patch I talked to roy to clarify some confusion I have. I agree to use such a less risk patch. r=shanjian
Attachment #102401 - Flags: review+
kin: can you super review again?
Comment on attachment 102401 [details] [diff] [review] Better patch sr=kin@netscape.com
Attachment #102401 - Flags: superreview+
Comment on attachment 102401 [details] [diff] [review] Better patch a=asa for checkin to 1.2beta (on behalf of drivers)
Attachment #102401 - Flags: approval+
fix checked into the trunk Please verify once we turn the MOZ_UNICODE flag on by default or provide a special unicode build (whichever comes first) Making 104934 as a depend.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Depends on: 104934
Is there any one can verify this on unicode build? thanks! FYI, there are unicode trunk builds availible on mozilla download site, e.g.: ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-11-01-08-unicode/
WFM in 2002110108 unicode build, w98.
Thanks. I'm marking this as verified per comment above.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: