1707076 - Alpenglow on Windows 7 classic mode doesn't show background images on tabs bar

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #1702480 +++

Preconditions

In about:config set:
browser.proton.enabled = true

Affected versions

Firefox 89.0a1

Affected platforms

Windows 7 x64

Steps to reproduce

1. Open Firefox.
2. Set the browser to Alpenglow
3. Observe the tabs bar.

Expected result

Background images should appear in the tabs bar

Actual Result

The tabs bar shows a white background

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1707076 - Draw the webextension-theme additonal backgrounds on Windows 7 and Windows 8 even if the header image isn't specified.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4c1a20756de
Draw the webextension-theme additonal backgrounds on Windows 7 and Windows 8 even if the header image isn't specified. r=desktop-theme-reviewers,Itiel

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_ext_themes_additional_backgrounds_alignment.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b6cd3dd5db8394db29ff1bfe667423f0aa4bc664
Log link: https://treeherder.mozilla.org/logviewer?job_id=338215680&repo=autoland&lineNumber=7006

Comment 4

[Pablo]

happens on nightly 90.0a1 and beta 89.0b6 but with high contrast enabled
the strange part is that its white if the window is not maximized, but if you maximize the firefox window it then takes the correct color

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b70c8f158ff3
Draw the webextension-theme additonal backgrounds on Windows 7 and Windows 8 even if the header image isn't specified. r=desktop-theme-reviewers,Itiel

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b70c8f158ff3

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Is that something we should uplift to beta or do we let it ride the 90 train? Thanks

Comment 8

[Romain Testard [:RT]]

We aligned that only P1 bugs and icons should be uplifted at this stage. 0.48% of Win7 users run ALpenglow, it seems like we should let this ride 90 given low impacted population and low severity when using Alpenglow.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Wontfix 89 as per comment #8

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Romain Testard [:RT] from comment #8)

We aligned that only P1 bugs and icons should be uplifted at this stage. 0.48% of Win7 users run ALpenglow, it seems like we should let this ride 90 given low impacted population and low severity when using Alpenglow.

I don't think this should be categorized as low severity. It's true that the browser still works, but anyone who is expecting Alpenglow and sees all white will be quite surprised. From a design perspective this is pretty severe, https://bug1702480.bmoattachments.org/attachment.cgi?id=9217789

I'd like to get QA verification on this and then revisit potential for uplift to beta.

Comment 11

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with Firefox 89.0a1 (2021-04-01) on windows 7 x32 bit. I can confirm that the issue is fixed with Firefox 90.0a1 (2021-05-05) on Windows 7. Will let the qe-verify+ tag in case the issue is uplifted to beta and will update the other flags accordingly.

Thank you!

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Redirecting, see comment #10. Can we uplift this now?

Comment 13

[Shilpa Mohanty]

Request for Uplift from the PM team.