1707111 - Remove host app checks from chatZilla

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

As we will always be running our forked chatZilla on SeaMonkey, we can remove the code that checks and does different things depending on the host app. Just keep the SeaMonkey code paths.

Comment 1

[Ian Neal]

Attachment: 1707111-irc-clienthost-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 7 strings removed

Comment 2

[Ian Neal]

I cannot see any use for client.hostPlatform so that could probably also be removed.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9217905 [details] [diff] [review]
1707111-irc-clienthost-2538.patch

LGTM

client.platform = "Unknown";
if (navigator.platform.search(/mac/i) > -1)

The client checks can be done with AppConstants.plattform in a follow-up.

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/9e80ce2856addd476a2bf36c7800dfce7dba5ff5
Remove host app checks from chatZilla. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5acbe64b5d3878a77c5dc2d6a8571ef0d8e768b4
Remove host app checks from chatZilla. r=frg a=frg