1707202 - Remove surface_origin_is_top_left support from NativeSurface again

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Robert Mader [:rmader]]

I.e. basically revert bug 1697673

Do so because:

• using native compositor integration implies the y-flip can be done by the system compositor - usually an no extra cost
• it was still incomplete and only used by the Wayland backend. Better not have any Wayland specific code paths, so we can be sure all Wayland specific bugs are in the dedicated backend
• reducing unnecessary complexity is always good

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1707202 - Remove surface_origin_is_top_left support from NativeSurface again, r=gw

Using native compositor integration should imply the y-flip can be
done by the system compositor - this is true for CA, DC and Wayland.
As the Wayland backend now does so, remove the
surface_origin_is_top_left support again, making sure
the Wayland backend uses the same code paths as CA/DC backends do.

Note:

• In order to not regress bug 1680128, do not revert the override
  of SurfaceOriginIsTopLeft() in RenderCompositorNative.h
• Explicitely set surface_origin_is_top_left: false in the example
  compositor. This is the default, however setting it explicitely
  would have helped me bring up the Wayland example compositor.
  This is purely a hint for potential future backends.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae3f3e51436
Remove surface_origin_is_top_left support from NativeSurface again, r=nical

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8ae3f3e51436