Closed
Bug 1707420
Opened 3 years ago
Closed 3 years ago
Add XPI_ROOT_APPID for 2.53 and 2.57 suite builds
Categories
(SeaMonkey :: Build Config, task)
SeaMonkey
Build Config
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.8)
Attachments
(1 file)
|
2.15 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
This is the equivalent of bug 1311005, some of the changes have already been done so this ports the remaining changes.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9218135 -
Flags: review?(frgrahl)
Attachment #9218135 -
Flags: approval-comm-release?
Attachment #9218135 -
Flags: approval-comm-esr60?
|
||
Comment 2•3 years ago
•
|
||
Comment on attachment 9218135 [details] [diff] [review]
1707420-xpi_root_appid-2538.patch
LGTM
xpi_root_appid is gone for central so only needed for 2.53 and 2.57
Attachment #9218135 -
Flags: review?(frgrahl)
Attachment #9218135 -
Flags: review+
Attachment #9218135 -
Flags: approval-comm-release?
Attachment #9218135 -
Flags: approval-comm-release+
Attachment #9218135 -
Flags: approval-comm-esr60?
Attachment #9218135 -
Flags: approval-comm-esr60+
|
|
||
Updated•3 years ago
|
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
|
|
||
Updated•3 years ago
|
Summary: Add XPI_ROOT_APPID for suite → Add XPI_ROOT_APPID for 2.53 and 2.57 suite builds
|
|
||
Comment 3•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c13318276d37093edff8ca9a2f37b119de184992
Add XPI_ROOT_APPID for suite. r=frg a=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•