1707469 - downloads.download failing with CRASH error code for specific URLs

Status: RESOLVED DUPLICATE of bug 1710251

(WebExtensions :: General, defect)

Description

[mark]

Attachment: test-issue.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

A user of Foxy Gestures has logged an issue about an Instagram URL that fails to download through the WE downloads.download API. He says the issue affects all Instagram URLs.

A sample URL is provided in this GitHub issue. https://github.com/marklieberman/foxygestures/issues/351 (Beware, the sample URL is an image of a woman in a very low cut top.)

I also attached a trivial WE that adds a context menu item called "Test Download" that calls browser.downloads.download() with the URL and console logs the downloads.onChanged event.

The same URL can be saved using built-in Save Image As... content menu item as well as wget and curl without issue.

Actual results:

The item is added to the downloads list, but immediately fails. A request appears in the Browser Console, but the transferred bytes is 0B.

The download state updated with an error and the error code is "CRASH".

Expected results:

The item should be downloaded successfully.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Micah [:mtigley] (she/her)]

This looks to be similar to Bug 1707457

Comment 4

[Marco Bonardo [:mak]]

The "CRASH" name is a bit unexpected here, it should probably be something like UNEXPECTED_FAIILURE or UNKNOWN_FAILURE:
https://searchfox.org/mozilla-central/rev/1ed1bb14eed9b3f27a94513387608436ea74c247/toolkit/components/extensions/parent/ext-downloads.js#246-253

I'm checking if there's a reg-range

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=03ed5ed6cba7190608c548578e9d79d82b0ccf83&tochange=49ca7598efc001126341cd6dfacfe030c13e2f45

Comment 6

[:Gijs (he/him)]

Looks like the server sends:

cross-origin-resource-policy:	same-origin

headers for the image, so I suspect this is an issue with the principal used for the download request from the webextension API.

(So to be clear, ideally the download should work, but even if/when that is fixed, the error reporting on the download towards the webextension could be improved, perhaps...)

Comment 7

[Dianna Smith [:diannaS]]

Is this still an S2?

Comment 8

[Shane Caraveo (:mixedpuppy)]

removing severity to push it into our triage

Comment 9

[Tomislav Jovanovic :zombie]

Rob, do you maybe have an idea what we should do here?

Comment 10

[Rob Wu [:robwu]]

Hmm. Looks like a needinfo from me for me fell through the cracks. I am aware of this bug and even sketched a solution at bug 1710251.