1707533 - [wayland] Custom cursors are downscaled in HiDPI

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: testcase

The test-case attached behaves differently on Wayland than on any other platform when in HiDPI. On wayland, it shrinks by the DPI scale, but on X11 / Windows / Mac it doesn't

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1707533 - Make Wayland custom cursors behave like all other platforms. r=stransky

It seems GTK downscales the cursor if the resolution is less than the
device scale, so this makes it consistent with X11 and all other desktop
platforms.

On the example on the bug it seems silly because the cursor is massive,
but on legit examples like:

https://downloads.scirra.com/labs/bugs/cursor-image-set/

This makes the cursor not abruptly change sizes when page zoom changes
for example.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a19cf8b431ce
Make Wayland custom cursors behave like all other platforms. r=stransky

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1cf116c7a3
GdkScaleFactor was renamed yesterday.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a19cf8b431ce
https://hg.mozilla.org/mozilla-central/rev/bb1cf116c7a3