Closed Bug 1707538 Opened 3 years ago Closed 3 years ago

Checkboxes and icons in modal dialogs are no longer aligned

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Desktop
Unspecified

Tracking

(firefox88 disabled, firefox89 verified, firefox90 verified)

VERIFIED FIXED
90 Branch
Tracking Status
firefox88 --- disabled
firefox89 --- verified
firefox90 --- verified

People

(Reporter: rdoghi, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-modals] [priority:2b] [proton-uplift])

Attachments

(3 files)

Attached image checkboxTEXT.png

[Affected platforms]:
Platforms: All

[Steps to reproduce]

  1. Have Zoom installed and Launch the Firefox Browser.
  2. Reach https://mozilla.zoom.us/j/73233092083 and click the Launch meeting button in order for the Protocol Handler modal to be displayed.

[Expected result]
The Checkbox label text should be a pixel higher.

[Actual result]
The Checkbox label text is aligned with the bottom of the Checkbox square.

Attached image ChooseAPP.png
Flags: needinfo?(gijskruitbosch+bugs)
No longer blocks: 1706592
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [proton-modals
Whiteboard: [proton-modals → [proton-modals]

Bah, didn't mean to clear needinfo.

Flags: needinfo?(gijskruitbosch+bugs)
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals] [priority:2b]

On current nightly, icons and checkboxes in other places have also lost some alignment, now that the font is smaller again. I'll try and fix that and the bug this originally highlighted, in the protocol handling dialogs.

Assignee: nobody → gijskruitbosch+bugs
Depends on: 1706415
Flags: needinfo?(gijskruitbosch+bugs)
Summary: The Checkbox label Text is a pixel lower than it should be on Protocol Handler modals → Checkboxes and icons in modal dialogs are no longer aligned
See Also: → 1707828
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0bf658f4c20e
align checkbox and modal icons correctly given changes in font-size, r=Mardak
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219303 [details]
Bug 1707538 - align checkbox and modal icons correctly given changes in font-size, r?Mardak

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0 and bug 1707828 - generally, please check icon and checkbox alignment in content (alert/prompt/confirm) modals, the protocol handling dialog, and the default browser dialog
  • List of other uplifts needed: None that haven't already been uplifted
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): We're translate ing some stuff in CSS to make it line up better. Shouldn't affect much else
  • String changes made/needed: Nope
Attachment #9219303 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Whiteboard: [proton-modals] [priority:2b] → [proton-modals] [priority:2b] [proton-uplift]

Comment on attachment 9219303 [details]
Bug 1707538 - align checkbox and modal icons correctly given changes in font-size, r?Mardak

Approved for 89 beta 7, thanks.

Attachment #9219303 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

This issue is Verified as fixed in our latest beta 89.0b8 and our latest Nightly 90.0a1 (2021-05-04) on Windows 10 , Mac 11 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: