1707555 - All thread actor options should be passed via the thread configuration actor.

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

For now, only pause on exception flags are passed via the thread configuration actor.
But we would have to do the same for all thread actor options if we want to enable server side target switching by default (bug 1698891). Otherwise, these flags won't be set correctly when we instantiate the target actor very early during the page load.

It would probably be easier to first expose a thread configuration command, so that we can simplify a bit TargetMixin's attachThread method.
These options are all these ones:
https://searchfox.org/mozilla-central/source/devtools/client/shared/thread-utils.js#20-49

Comment 1

[Alexandre Poirot [:ochameau]]

After bug 1707556 is done, we should probably have the thread configuration to mimic what is currently done in TargetMixin:
https://searchfox.org/mozilla-central/source/devtools/client/fronts/targets/target-mixin.js#514-519

      const options = await getThreadOptions();
      // If the target is destroyed or soon will be, don't go further
      if (this.isDestroyedOrBeingDestroyed()) {
        return;
      }
      const threadFront = await this.attachThread(options);

And fetch default options via getThreadOptions and pass these options to the ThreadConfigurationAtor via updateConfiguration.
And that work should probably be called from the toolbox, around these lines:
https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/devtools/client/framework/toolbox.js#792-823
Doing this before watchTargets sounds like a good option, it would allow to have the configuration set before creating the targets.

The most complex part here would probably be to handle backward compat and avoid passing options from TargetActorMixin once we pass them all via thread configuration. Note that we can probably still pass the options the two ways, but it would be nice to pass them only once for performance reasons. Once we use the thread configuration, we pass the options only once to the server and the server dispatch the options to all the contexts. We no longer need to pass the options manually to each individual thread actor from the frontend!

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1707555 - [devtools] Use thread configuration actor for all thread options r=ochameau

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6004cc4ec83
[devtools] Use thread configuration actor for all thread options r=ochameau

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c6004cc4ec83