1707692 - Annotate XPIDL method/getter/setter calls with profiler labels for the IDL method name (NS_InvokeByIndex, XPCWrappedNative, CallMethodHelper)

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Markus Stange [:mstange]]

Example profile: https://share.firefox.dev/3vg3Wj2

When JS calls C++ code via an XPIDL method, we inherit the JavaScript profiler category into the C++ part of the stack.

It would be great if we could display the interface + method name of the called code and switch to the DOM category, like we do for WebIDL APIs.

In the example profile, this would be the call to GfxInfoBase::GetContentBackend, which is accessed through get nsIGfxInfo.ContentBackend.

Comment 1

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1707692 - WIP: Annotate XPIDL method/getter/setter calls with profiler labels for the IDL method name.

Profile with patch: https://share.firefox.dev/2S4zsCy

Todo:

• Write a test.
• Maybe add a comment or two.
• Figure out if anything needs to be done to handle symbols, or if <symbol> is an acceptable fallback.

Comment 2

[Markus Stange [:mstange]]

One useful comment to add to the code would be that the goal is to match WebIDL profiler labels, which also use the DOM category.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1707692 - Annotate XPIDL method/getter/setter calls with profiler labels for the IDL method name, original patch by mstange. r=nika

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395537045072
Annotate XPIDL method/getter/setter calls with profiler labels for the IDL method name, original patch by mstange. r=nika

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/395537045072