1707738 - Fix and re-enable test_protocolproxyservice.js on Apple Silicon

Status: NEW

(Core :: Networking: Proxy, task, P2)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Last week we turned on tests for Apple Silicon (OSX 11.2.3 on new Apple based hardware). We are using the simplified new test config process:
https://firefox-source-docs.mozilla.org/testing/ci-configs/index.html

As the tests are live, we are now filing bugs to help close the loop and hope to fix any issues over the next 7 weeks. As the process outlines, there are tier-3 jobs running on m-c which run these skipped tests and will expect a failure/timeout/crash- if it doesn't fail, then the job will turn orange.

Here is a failing test:
netwerk/test/browser/browser_child_resource.js

here is another failing test:
netwerk/test/unit/test_protocolproxyservice.js

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:jstutte- a heads up that a couple of tests are disabled on the new apple_silicon platform- no urgency, but wanted to make sure you as a triage owner were aware of this.

Comment 2

[Jens Stutte [:jstutte]]

Hi Joel, thanks for the heads up. Can we expect specific bugs to be filed for those test failures in case our action is needed? I am just not sure, if we have an action here and if yes, which.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Hi :jstutte- the goal was to file a single bug/component. As a heads up we turned off these tests yesterday to update the machines and fix some issues withe x86_86 vs arm64 runtime environment- I will update the bugs when the tests are on again.

Comment 4

[[e-mail] (:bhearsum)]

netwerk/test/unit/test_protocolproxyservice.js

These tests have been largely re-enabled. Here's a new log for this test: https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=macosx1100&revision=eac40293649628d32911c909219d514bebb8ce63&test_paths=netwerk%2Ftest%2Funit&selectedTaskRun=dmCjMsSzT7aLxeToJB2KsA.0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

test_protocolproxyservice.js still fails on Apple Silicon. Here's an updated failure log:

   INFO -  "CONSOLE_MESSAGE: (info) PAC file installed from data: URI"
   INFO -  TEST-PASS | netwerk/test/unit/test_protocolproxyservice.js | myipaddress_callback - {"QueryInterface":"function QueryInterface() {\\n    [native code]\\n}","host":"127.0.0.1","port":1234,"type":"http","flags":0,"resolveFlags":0,"username":"","password":"","failoverTimeout":1800,"failoverProxy":null,"sourceId":"","proxyAuthorizationHeader":"","connectionIsolationKey":"","TRANSPARENT_PROXY_RESOLVES_HOST":1} != null
   INFO -  TEST-PASS | netwerk/test/unit/test_protocolproxyservice.js | myipaddress_callback - "http" == "http"
   INFO -  TEST-PASS | netwerk/test/unit/test_protocolproxyservice.js | myipaddress_callback - 1234 == 1234
   INFO -  TEST-PASS | netwerk/test/unit/test_protocolproxyservice.js | myipaddress_callback - "127.0.0.1" != null
WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_protocolproxyservice.js | myipaddress_callback - "127.0.0.1" != "127.0.0.1"
   INFO -  /opt/worker/tasks/task_1672691430/build/tests/xpcshell/tests/netwerk/test/unit/test_protocolproxyservice.js:myipaddress_callback:854
   INFO -  /opt/worker/tasks/task_1672691430/build/tests/xpcshell/tests/netwerk/test/unit/test_protocolproxyservice.js:onProxyAvailable:164
   INFO -  /opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:_do_main:238
   INFO -  /opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:_execute_test:585
   INFO -  -e:null:1
   INFO -  exiting test
   INFO -  PID 8092 | JavaScript error: /opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js, line 863: NS_ERROR_ABORT:
   INFO -  "CONSOLE_MESSAGE: (error) 
   INFO -  _abort_failed_test@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:863:20
   INFO -  do_report_result@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:964:5
   INFO -  Assert<@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:71:21
   INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:240:10
   INFO -  notEqual@resource://testing-common/Assert.sys.mjs:300:8
   INFO -  myipaddress_callback@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/tests/netwerk/test/unit/test_protocolproxyservice.js:854:10
   INFO -  onProxyAvailable@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/tests/netwerk/test/unit/test_protocolproxyservice.js:164:10
   INFO -  _do_main@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:238:6
   INFO -  _execute_test@/opt/worker/tasks/task_1672691430/build/tests/xpcshell/head.js:585:5
   INFO -  @-e:1:1

Comment 6

[Valentin Gosu [:valentin] (he/him)]

This is easily reproducible.
The bug seems to come from a behaviour change on apple silicon and ProxyAutoConfig::MyIPAddress no longer returns the expected result.

Comment 7

[BMO Automation]

Moving bug to Core/Networking: Proxy.