Closed Bug 1707740 Opened 4 years ago Closed 4 years ago

Site permission panel close icons are too large

Categories

(Firefox :: Site Permissions, enhancement, P1)

Product:
Firefox
Component:
Site Permissions
Version:
Firefox 89
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: emmamalysz, Assigned: emmamalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-door-hangers] [proton-uplift])

Attachments

(1 file)

Bug 1707740, reduce size of close icons in site permissions panel
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

UX requested that we change the close icon dimensions to 12x12.

Note Bug 1703476 made it into the 89 branch, so we're not waiting on uplift there.

Summary: Site permission panel is missing a number of Proton styles → Site permission panel close icons are too large
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39d97dcd4c15 reduce size of close icons in site permissions panel r=mconley

https://hg.mozilla.org/mozilla-central/rev/39d97dcd4c15

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Emma, do you want to request uplift to beta?

Flags: needinfo?(emalysz)

Comment on attachment 9218482 [details]
Bug 1707740, reduce size of close icons in site permissions panel

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): no string changes
  • String changes made/needed: n/a
Flags: needinfo?(emalysz)
Attachment #9218482 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [proton-uplift]

Comment on attachment 9218482 [details]
Bug 1707740, reduce size of close icons in site permissions panel

Approved for 89 beta 6, thanks.

Attachment #9218482 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: