1707799 - Perma clang-trunk /builds/worker/checkouts/gecko/accessible/generic/LocalAccessible.cpp:2455:20: error: variable 'selected' set but not used [-Werror,-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=337810935&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aKukIRu3Q8CFW67jCIoWgg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-04-27T02:39:41.934Z] 02:39:41     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o nsGNOMEShellDBusHelper.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 '-DMOZ_APP_DISPLAYNAME="Nightly"' '-DMOZ_APP_NAME="firefox"' '-DMOZ_APP_VERSION="90.0a1"' -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/browser/components/shell -I/builds/worker/workspace/obj-build/browser/components/shell -I/builds/worker/checkouts/gecko/xpcom/build -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/harfbuzz -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pixman-1 -I/builds/worker/fetches/sysroot/usr/include/freetype2 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/builds/worker/fetches/sysroot/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -fexperimental-new-pass-manager  -MD -MP -MF .deps/nsGNOMEShellDBusHelper.o.pp   /builds/worker/checkouts/gecko/browser/components/shell/nsGNOMEShellDBusHelper.cpp
[task 2021-04-27T02:39:41.934Z] 02:39:41     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/components/shell'
[task 2021-04-27T02:39:41.945Z] 02:39:41     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/browser/components/shell'
[task 2021-04-27T02:39:41.945Z] 02:39:41     INFO -  browser/components/shell/nsGNOMEShellService.o
[task 2021-04-27T02:39:41.946Z] 02:39:41     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/components/shell'
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/generic'
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_accessible_generic0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/accessible/generic -I/builds/worker/workspace/obj-build/accessible/generic -I/builds/worker/checkouts/gecko/accessible/base -I/builds/worker/checkouts/gecko/accessible/html -I/builds/worker/checkouts/gecko/accessible/xpcom -I/builds/worker/checkouts/gecko/accessible/xul -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/accessible/ipc/other -I/builds/worker/checkouts/gecko/accessible/atk -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_accessible_generic0.o.pp   Unified_cpp_accessible_generic0.cpp
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -  In file included from Unified_cpp_accessible_generic0.cpp:65:
[task 2021-04-27T02:39:42.523Z] 02:39:42    ERROR -  /builds/worker/checkouts/gecko/accessible/generic/LocalAccessible.cpp:2455:20: error: variable 'selected' set but not used [-Werror,-Wunused-but-set-variable]
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -    LocalAccessible* selected = nullptr;
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -                     ^
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -  1 error generated.
[task 2021-04-27T02:39:42.523Z] 02:39:42    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_accessible_generic0.o] Error 1
[task 2021-04-27T02:39:42.523Z] 02:39:42     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/generic'
[task 2021-04-27T02:39:42.524Z] 02:39:42    ERROR -  make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: accessible/generic/target-objects] Error 2
[task 2021-04-27T02:39:42.524Z] 02:39:42     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2021-04-27T02:39:42.524Z] 02:39:42     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/mfbt'
[task 2021-04-27T02:39:42.525Z] 02:39:42     INFO -  mfbt/Unified_cpp_mfbt1.o
[task 2021-04-27T02:39:42.525Z] 02:39:42     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/mfbt'```

Comment 1

[Andi [:andi]]

Attachment: Bug 1707799 - when building with clang-trunk do not treat some warnings as errors.

Since we run clang trunk builds on m-c and m-r we should not treat some warnings
as errors until we don't fix them in m-c and they propagate in m-r.

Comment 2

[Andi [:andi]]

Attachment: Bug 1707799 - revert patch D100581 from LLVM that added `-Wunused-but-set-parameter and -Wunused-but-set-variable`. r=marco

Until we fix the issues from m-c and they get propagated to m-r we should disable this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8153e98fe308
revert patch D100581 from LLVM that added `-Wunused-but-set-parameter and -Wunused-but-set-variable`. r=firefox-build-system-reviewers,mhentges

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8153e98fe308

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 8153e98fe308 (Bug 1707799) because D100581 has been reverted from the llvm repo. a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/34a5ed6d487b2f42ff6b1318f0c00080a0e02770

Comment 6

[Intermittent Failures Robot]

2 failures in 3706 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform and build breakdown:

• linux64: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1707799&startday=2021-04-26&endday=2021-05-02&tree=all