170781 - check boxes do not work and do not show correctly

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Phil Lohnes]

NOte I am using Mozilla 1.1

I went to this page which worked fine, except that the check boxes did not 
appear to the left of the text and no amount of clicking on the text line would 
check them (after clicking submit the next page tells you that you haven't 
selected anything, the boxes work right with IE 5.5)

Below is the source used to make the check boxes.



<pre>
<font size=-1 face=tahoma color="#cc0000" >I am interested in: (required entry)
</font>
 <font size=-1 face=tahoma >
<input align=right name=Interested_in type="checkbox" accept=" " 
value="IND">1040 Individual Tax 
<input align=right name=Interested_in type=checkbox value=PART>1065 Partnership 
Tax
<input align=right name=Interested_in type=checkbox value=CORP>1120 Corporate 
Tax 
<input align=right name=Interested_in type=checkbox value=SCORP>1120S  S 
Corporation Tax 
<input align=right name=Interested_in type=checkbox value=FID>1041 Fiduciary 
Tax 
<input align=right name=Interested_in type=checkbox value=ESTATE>706, 709 &amp; 
990 Programs 

<input align=right name=Interested_in type=checkbox value=5500>5500 Benefit Plan
<input align=right name=Interested_in type=checkbox value=TP>Tax Planner
<input align=right name=Interested_in type=checkbox 
value=Consolidated_Corporation>Consolidated Corporation 
<input align=right name=Interested_in type=checkbox value=REP>Remote Entry 
Processing (pay-per-return)
<input align=right name=Interested_in type=checkbox value=EF>Electronic Filing
<input align=right name=Interested_in type=checkbox value=LPP>Presentation 
Products <br>

Comment 1

[Boris Zbarsky [:bzbarsky]]

The're on the right because they are floated right. You can't click them because
the text overlaps them.

jkeiser, perhaps checkboxes should just ignore the align attribute?

Comment 2

[John Keiser (jkeiser)]

Fine, I suppose for all inputs, we should in fact make align do text-align.  I
see no need to ignore it specifically, and it will probably allow us not to have
an if.  I am checking in the other patch you made to do align=* tonight.  I will
make a patch after that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

<input type="image"> should be floated by align, imo...

Comment 4

[John Keiser (jkeiser)]

Attachment: Patch

This fixes everything except input type=file for some reason.  Not sure if that
shall be a separate bug or what.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 109717 [details] [diff] [review]
Patch

+      // Images treat align as "float"

Put that comment right before the call to
nsGenericHTMLElement::MapAlignAttributeInto, perhaps?

Also, the indentation looks wacky (two-space in the else, 4-space or tab in the
if).

sr=bzbarsky with those issues fixed.

Comment 6

[Peter Lubczynski]

Comment on attachment 109717 [details] [diff] [review]
Patch

r=peterl

Comment 7

[John Keiser (jkeiser)]

Fix checked in.

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 176317 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 180401 has been marked as a duplicate of this bug. ***