1707946 - Move usage of Promise.jsm to regular DOM Promises in devtools/client/inspector/markup/markup.js

Status: RESOLVED FIXED

(DevTools :: Inspector, task)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

an initial patch revealed some test failures, as pending Promise.jsm promises don't cause test failure (?) + another one that seems to be caused by slight change in timing. I'll update those tests

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1707946 - [devtools] Replace Promise.jsm with regular Promises in devtools/client/inspector/markup/markup.js. r=ochameau.

This was making 2 tests failing:

• browser_toolbox_selectionchanged_event.js had a pending promise that would make
  the test fail (whereas pending Promise.jsm don't). It was setting an undefined
  selected node with a reason, which is something we don't do in the codebase (we set
  it to null, with no reason). So here we change it by setting the selection to a
  null node, which is consistent with real world scenario.
• browser_markup_shadowdom_clickreveal.js was failing because the container of
  a node was slotted while it shouldn't be. It looks like the switch to DOM Promises
  changed the timing slightly, so we're now waiting in the test to make sure we
  have another container than the slotted one we were handling before.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36de91ab59b9
[devtools] Replace Promise.jsm with regular Promises in devtools/client/inspector/markup/markup.js. r=ochameau.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/36de91ab59b9