1707947 - Search bar elements appear to be misaligned after the proton redesign

Status: RESOLVED WORKSFORME

(Firefox :: Search, enhancement, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: unaligned

Affected versions

• Fx89.0b4

Affected platforms

• Windows 10
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox.
2. Go to about:preferences#search and add the search bar to the toolbar.
3. Perform several search using the search (or address bar).
4. Open a new tab and click inside the search bar.
5. On the keyboard press the 'down' arrow.
6. Observe the 'Change Settings' text.

Expected result

• Either center or aligned to the rest of the text displayed in the drop-down.

Actual result

• Text appears to be misaligned.

Regression range

• This is not a regression (part of the new re-design).

Additional notes

• The button seems to be aligned to the other engines, but the text looks misaligned because its spacing from the button border.
• See the attachment for more details.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The button should be aligned like other similar menuitems, for example the Manage Bookmarks, or Manage History, or Show all Downloads. And that looks correct to me.
The exotic things here are all the other entries honestly.
But we can't really change the alignment of suggestions, they depend on the input field text alignment.

We could re-align the shortcut buttons, especially the "This time search with" header, could be aligned with the Search Settings text.
We could also alternatively just switch the search bar to the urlbar shortcuts compact mode, I'm not sure why we still keep it different.

This is a very low priority, imo.

Comment 2

[Mark Banner (:standard8)]

Change Search Settings is now a smaller button as part of the same area as the one-off buttons, I think the remaining layout is consistent with other parts of the UI.