1707977 - Crash in [@ nsPrintJob::DoPrint]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

~620 crashes for the Firefox 87 cycle in crash stats, >95% of crashes on Windows 7, >85% with x86 builds. This took off with Firefox 86 (tab modal print UI?).

Crash report: https://crash-stats.mozilla.org/report/index/c110d8e0-e25a-470a-87fe-4d4740210427

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll nsPrintJob::DoPrint layout/printing/nsPrintJob.cpp:2125
1 xul.dll nsPrintJob::PrintDocContent layout/printing/nsPrintJob.cpp:1948
2 xul.dll nsPrintJob::SetupToPrintContent layout/printing/nsPrintJob.cpp:1420
3 xul.dll nsPrintJob::MaybeResumePrintAfterResourcesLoaded layout/printing/nsPrintJob.cpp:1546
4 xul.dll nsPrintJob::InitPrintDocConstruction layout/printing/nsPrintJob.cpp:1493
5 xul.dll nsPrintJob::DoCommonPrint layout/printing/nsPrintJob.cpp:804
6 xul.dll nsPrintJob::CommonPrint layout/printing/nsPrintJob.cpp:479
7 xul.dll nsPrintJob::Print layout/printing/nsPrintJob.cpp:822
8 xul.dll nsDocumentViewer::Print layout/base/nsDocumentViewer.cpp:2981
9 xul.dll nsGlobalWindowOuter::Print dom/base/nsGlobalWindowOuter.cpp:5393

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1707977 - Null-check print data in nsPrintJob::DoPrint. r=#layout-reviewers

It's unclear how this can happen (the caller also null-checks, but then
again it also reconstructs a bunch of stuff, so...).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e6e8633e49e
Null-check print data in nsPrintJob::DoPrint. r=layout-reviewers,dholbert

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e6e8633e49e

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9219264 [details]
Bug 1707977 - Null-check print data in nsPrintJob::DoPrint. r=#layout-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null-check
• String changes made/needed: none

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219264 [details]
Bug 1707977 - Null-check print data in nsPrintJob::DoPrint. r=#layout-reviewers

Low risk patch for a significant crasher on beta/release when printing, approved for 89 beta 9, thanks!

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c7a4d037ecca