Update or stop using testActor in test reloading the test page
Categories
(DevTools :: Inspector, enhancement)
Tracking
(Fission Milestone:M8, firefox91 fixed)
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file, 1 obsolete file)
When enabling bug 1698891, a couple of tests start breaking because the testActor is still using the previous, destroyed target.
That's because when we enable bug 1698891, each navigation/reload will spawn a new target and testActor uses only one target, the first one.
There is two ways to address that:
- update testActor after each navigation,
- stop using the testActor in test involving navigations.
Reporter | ||
Comment 1•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
devtools/client/inspector/rules/test/browser_rules_eyedropper.js is current failing with bfcache in parent:
./mach mochitest devtools/client/inspector/rules/test/browser_rules_eyedropper.js --enable-fission --setpref fission.bfcacheInParent=true --headless
And this bug may address this failure.
Assignee | ||
Comment 3•3 years ago
|
||
with my patches applied, the test run fine with bfcacheInParent enabled
Assignee | ||
Comment 4•3 years ago
|
||
The test opens the inspector and retrieves the testActor,
then a navigation occurs and testActor is used to check
if the highlighter works.
When server-side target switching is enabled, the testActor
gets destroyed during the navigation, and when it throws
when we try to use it in the new document.
To fix this, we only retrieve the testActor once we navigated.
Depends on D117263
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d1c24eeb026 [devtools] Fix testActor usage in browser_inspector_highlighter-05.js. r=ochameau.
Comment 6•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•