Closed Bug 1708106 Opened 2 months ago Closed 9 days ago

Update or stop using testActor in test reloading the test page

Categories

(DevTools :: Inspector, enhancement)

enhancement

Tracking

(Fission Milestone:M8, firefox91 fixed)

RESOLVED FIXED
91 Branch
Fission Milestone M8
Tracking Status
firefox91 --- fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file, 1 obsolete file)

When enabling bug 1698891, a couple of tests start breaking because the testActor is still using the previous, destroyed target.
That's because when we enable bug 1698891, each navigation/reload will spawn a new target and testActor uses only one target, the first one.

There is two ways to address that:

  • update testActor after each navigation,
  • stop using the testActor in test involving navigations.
Whiteboard: dt-fission-m3-triage
Fission Milestone: --- → M8
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Depends on: 1713557
Depends on: 1713560
Depends on: 1713568

devtools/client/inspector/rules/test/browser_rules_eyedropper.js is current failing with bfcache in parent:
./mach mochitest devtools/client/inspector/rules/test/browser_rules_eyedropper.js --enable-fission --setpref fission.bfcacheInParent=true --headless
And this bug may address this failure.

with my patches applied, the test run fine with bfcacheInParent enabled

The test opens the inspector and retrieves the testActor,
then a navigation occurs and testActor is used to check
if the highlighter works.
When server-side target switching is enabled, the testActor
gets destroyed during the navigation, and when it throws
when we try to use it in the new document.
To fix this, we only retrieve the testActor once we navigated.

Depends on D117263

Depends on: 1715574
Depends on: 1715577
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d1c24eeb026
[devtools] Fix testActor usage in browser_inspector_highlighter-05.js. r=ochameau.
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Attachment #9218863 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.