1708154 - Mute/Unmute icons aren't displayed correctly on Ubuntu 20.04 using system theme

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Hani Yacoub, Desktop QA]

Attachment: Ubuntu system theme.png

Affected versions

Firefox 90.0a1

Affected platforms

Ubuntu 20.04 x64

Steps to reproduce

1. Open Firefox.
2. Play a video on youtube.
3. Pin the tab.
4. Mute and unmute the tab.
5. Observe play/mute icon.

Expected result

Mute/Unmute icons should be displayed correctly on Ubuntu 20.04 using system theme.

Actual Result

Mute/Unmute icons aren't displayed correctly on Ubuntu 20.04 using system theme.

Note

The issue is only reproducible using System theme.
Ubuntu window colors: Light and Standard/

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1708154 - Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19e634663e84
Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast. r=desktop-theme-reviewers,dao

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/19e634663e84

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

This is set at priority:2b and is a CSS change, is that something we should uplift to beta or do we let it ride the 90 train? Thanks

Comment 5

[Hani Yacoub, Desktop QA]

Verified on Firefox Nightly 90.0a1 (2021-05-04) on Ubuntu 20.04 x64.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

This is a simple CSS change and not uplifting it to beta will introduce extra complexity when uplifting some icons changes (bug 1706084). I think we should reconsider marking this as wontfix for Firefox89.

Comment 7

[Romain Testard [:RT]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)

This is a simple CSS change and not uplifting it to beta will introduce extra complexity when uplifting some icons changes (bug 1706084). I think we should reconsider marking this as wontfix for Firefox89.

Thanks for the ping, agreed that if uplift is low risk and makes icon changes simpler we should do it.
OK to uplift to 89.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

jared, could you request the uplift? Thanks

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9219003 [details]
Bug 1708154 - Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast.

Beta/Release Uplift Approval Request

• User impact if declined: Mute and unmute icons in tabs won't appear correct on Linux when using the default theme
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small, well-contained, CSS-only patch that only affects tab badges.
• String changes made/needed: None.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219003 [details]
Bug 1708154 - Set the fill color at the same time as setting the stroke to make sure there will always be proper foreground/background contrast.

Low risk, blocks uplifting bug 1706084, , approved for 89 beta 10, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/87bf35d61337

Comment 12

[Hani Yacoub, Desktop QA]

Verified as fixed on Ubuntu 20.04 x64 on Firefox 89.0b10.