170822 - Linkification process destroys whitespace

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

Currently, the linkification process destroys whitespace - it's preserved, but
the output template doesn't use <pre> tags and so the browser collapses it.

We should use <pre> tags, and make it more obvious what's going on on the page.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Use <pre> tags to preserve whitespace, add <hr>s for separation.

Gerv

Comment 2

[Gervase Markham [:gerv]]

kiko: you reviewed the original. Can you rubber-stamp this tiny improvement? It
makes the whole thing behave much more like someone would expect.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 100629 [details] [diff] [review]
Patch v.1

You need to not indent the quoteurls thing, and/or use [%- -%], or you get
extra spacings - see comments.html.tmpl

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.2

v.2 - with review fixes.

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

Comment on attachment 100790 [details] [diff] [review]
Patch v.2

r=bbaetz

Comment 6

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v
 <--  linkify.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/pages/linked.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linked.html.tmpl,v
 <--  linked.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Gerv