1708325 - Run a repeat 'extra' paint in the middle of vsync intervals for user input

Status: RESOLVED FIXED

(Core :: Web Painting, task, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Bug 1675614 added a way for us to start a paint late during vsync if we hadn't already painted that interval.

We can also do an extra paint (with the hope of replacing the existing one on the compositor side) to reduce input latency when there are other changes happening (especially animations).

The current plan is to restrict this to changes triggered directly from user input, and to only allow one extra paint per vsync. We're going to use the same vsync timestamp for rAF so that script driven animations aren't adjusted by this extra paint.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1708325 - Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r?mstange

This makes it easier to understand and will make it easier to not include 'extra' frames (as we're hoping they will coalesce with the original frame on the compositor).

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1708325 - Allow doing an extra refresh driver tick for user input events. r?mstange!,Bas!

Depends on D113736

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edf1ac18cc8c
Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange
https://hg.mozilla.org/integration/autoland/rev/3fe338644983
Allow doing an extra refresh driver tick for user input events. r=mstange,bas

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1708325) for Build bustages in gecko/layout/base/nsRefreshDriver.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=339216810&repo=autoland&lineNumber=7712

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=3fe338644983f2459578097142f226d92aaa41c5

Backout:
https://hg.mozilla.org/integration/autoland/rev/097c1423b6f117fe70d3a2b6bb0b2610965046ea

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c26142ed63a9
Change frame throttling code in nsRefreshDriver to explicitly track the pending frames. r=mstange
https://hg.mozilla.org/integration/autoland/rev/ed8ff73df9a2
Allow doing an extra refresh driver tick for user input events. r=mstange,bas

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c26142ed63a9
https://hg.mozilla.org/mozilla-central/rev/ed8ff73df9a2