The extensions' doorhangers don't have rounded corners when webrender is enabled
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
firefox90 | --- | verified |
People
(Reporter: tgnff242, Assigned: gw)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: nightly-community, regression, Whiteboard: [proton-door-hangers])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0
Steps to reproduce:
- Install an extension with a toolbar icon that opens a menu, such as Mozilla's own containers extension.
- Ensure that proton and webrender are enabled.
- Left-click on the extension's toolbar icon to open the doorhanger.
Actual results:
The corners of the doorhanger are not rounded.
Expected results:
This is a regression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8d91b346e6b5f5efbe347521f8c1bbcd5c10c88a&tochange=6527552f2b2809528c69db127d813bf0a065d44c
Since the bug is restricted, I can't know whether the issue is already known or not.
Bugzilla doesn't let me to add 1700235 as the regressed bug.
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Already in gfx-triage. Not sure how important it is. Marking S3
Assignee | ||
Comment 4•3 years ago
|
||
If an iframe has complex clips, we need to skip including them
in the iframe specific clip applied to the tile cache, as that
path only supports rectangle clips.
Updated•3 years ago
|
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c56cf2509c45 Fix rounded clips on root iframe tile caches. r=gfx-reviewers,lsalzman
Comment 6•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Wouldn't we want to request uplift for this to beta?
Comment 8•3 years ago
|
||
Yes, given that the regressing bug is something we're intending to uplift.
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9220005 [details]
Bug 1708337 - Fix rounded clips on root iframe tile caches.
Beta/Release Uplift Approval Request
- User impact if declined: Rounded corners don't draw on some popups
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Per bug report
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fixes a clear rendering bug, change is straightforward.
- String changes made/needed:
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment on attachment 9220005 [details]
Bug 1708337 - Fix rounded clips on root iframe tile caches.
Fix for a visual regression in doorhangers in 89, approved for 89 beta 10, thanks.
Comment 11•3 years ago
|
||
bugherder uplift |
Comment 12•3 years ago
|
||
I've reproduced this issue using the steps from comment 0, on an affected Nightly build (2021-04-28).
The fix is verified as fixed on the latest builds: Nightly 90.0a1 and Beta 89.0b10. I've tested the bug running macOS 10.15, Ubuntu 18.04 x64 and Win 10 x64.
Description
•