1708382 - Building with rust 1.52 with warnings as errors fails with proc-macro-hack-compat error

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-04-29T07:39:50.455Z] 07:39:50     INFO -  error: using `procedural-masquerade` crate
[task 2021-04-29T07:39:50.455Z] 07:39:50     INFO -    --> toolkit/components/cascade_bloom_filter/src/lib.rs:24:1
[task 2021-04-29T07:39:50.455Z] 07:39:50     INFO -     |
[task 2021-04-29T07:39:50.456Z] 07:39:50     INFO -  24 | / rental! {
[task 2021-04-29T07:39:50.456Z] 07:39:50     INFO -  25 | |     mod rentals {
[task 2021-04-29T07:39:50.456Z] 07:39:50     INFO -  26 | |         use super::Cascade;
[task 2021-04-29T07:39:50.456Z] 07:39:50     INFO -  27 | |
[task 2021-04-29T07:39:50.457Z] 07:39:50     INFO -  ...  |
[task 2021-04-29T07:39:50.457Z] 07:39:50     INFO -  33 | |     }
[task 2021-04-29T07:39:50.457Z] 07:39:50     INFO -  34 | | }
[task 2021-04-29T07:39:50.457Z] 07:39:50     INFO -     | |_^
[task 2021-04-29T07:39:50.458Z] 07:39:50     INFO -     |
[task 2021-04-29T07:39:50.458Z] 07:39:50     INFO -     = note: `-D proc-macro-back-compat` implied by `-D warnings`
[task 2021-04-29T07:39:50.458Z] 07:39:50     INFO -     = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-04-29T07:39:50.459Z] 07:39:50     INFO -     = note: for more information, see issue #83125 <https://github.com/rust-lang/rust/issues/83125>
[task 2021-04-29T07:39:50.459Z] 07:39:50     INFO -     = note: The `procedural-masquerade` crate has been unnecessary since Rust 1.30.0. Versions of this crate below 0.1.7 will eventually stop compiling.
[task 2021-04-29T07:39:50.459Z] 07:39:50     INFO -     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-04-29T07:39:50.460Z] 07:39:50    ERROR -  error: aborting due to previous error
[task 2021-04-29T07:39:50.460Z] 07:39:50     INFO -  error: could not compile `cascade_bloom_filter`

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1708382 - Inline rust_warning_flags into rust_flags.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1708382 - Allow proc-macro-back-compat warning when building with rustc >= 1.52.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a826cae9cf9
Inline rust_warning_flags into rust_flags. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/f62a3883ad15
Allow proc-macro-back-compat warning when building with rustc >= 1.52. r=firefox-build-system-reviewers,mhentges

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0a826cae9cf9
https://hg.mozilla.org/mozilla-central/rev/f62a3883ad15