1708386 - Add an evaluation result message when using the `copy` helper

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate copy(1 + 1)

Expected results

A message is added in the console telling the user that a message was added to the clipboard, for example:

The following string was copied to clipboard: "2"

Actual results

No messages are displayed and the user has no way to know if the evaluation was successful or not.

Comment 1

[Claudia Batista [:claubatista]]

Hi! I was able to reproduce.
I'd like to work on this bug. :)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks Claudia,

So you might want to take a look at https://searchfox.org/mozilla-central/rev/da25888c4495585c532640f0e5efad07b1037621/devtools/client/webconsole/actions/input.js#203-204 where we do put the string (that the server sent us) into the clipboard.

In the same function, you can see how we add message to the console here https://searchfox.org/mozilla-central/rev/da25888c4495585c532640f0e5efad07b1037621/devtools/client/webconsole/actions/input.js#262-272
(the message is localized so we can have translation in multiple languages; the string is defined in https://searchfox.org/mozilla-central/rev/da25888c4495585c532640f0e5efad07b1037621/devtools/client/locales/en-US/webconsole.properties#433-436)

Let me know if you have any question!

Comment 3

[Claudia Batista [:claubatista]]

Attachment: Bug 1708386 - [devtools] Add an evaluation result message when using the `copy` helper. r=nchevobbe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e25200b8eb84
[devtools] Add an evaluation result message when using the `copy` helper. r=nchevobbe

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e25200b8eb84