1708411 - 6.23% build times (Linux) regression on Thu April 22 2021

Status: RESOLVED WORKSFORME

(Core :: DOM: Security, defect)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push 79592804bb542c4397f8ac90e511085e0741a827. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
6%	build times		linux64-shippable	nightly taskcluster-m5dn.4xlarge	2,370.46 -> 2,518.07

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1706577

Comment 2

[Julien Cristau [:jcristau]]

The identified regressor seems rather unlikely... It landed close to bug 1616238 though, so is there a chance this is a duplicate of bug 1707829 / bug 1708410?

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

I am quickly checking in here just to make sure the patch does not get backed out. I am keeping my ni? for now but wanted to explicitly mention that https-first-mode is disabled by default.

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

We did some retriggers to confirm the culprit.

Comment 5

[Andra Esanu (needinfo me)]

Clearing need info since the issue was addressed.

Comment 6

[Daniel Veditz [:dveditz]]

Closing based on comment 5 and the perf graphs