1708422 - Fortify code around `mozInlineSpellChecker::DoSpellCheck`

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 1) Factor `mozInlineSpellChecker::AddRangesForMisspelledWords` out. r=smaug

Abstracts details away.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 2) Rename `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug

Clearer.

Depends on D113779

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54bd4ad99198
part 1) Factor `mozInlineSpellChecker::AddRangesForMisspelledWords` out. r=smaug
https://hg.mozilla.org/integration/autoland/rev/33da227d7651
part 2) Rename `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/54bd4ad99198
https://hg.mozilla.org/mozilla-central/rev/33da227d7651

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: WIP: Bug 1708422: part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: WIP: Bug 1708422: part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`

Should help to simplify it. Please read the following reviews before
commenting on this one.

Depends on D114095

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`. r=smaug

Should help to simplify it. Please read the following reviews before
commenting on this one.

Depends on D114097

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 5) Surround statements in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute` with curly braces. r=smaug

To match the style guide.

Depends on D114098

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 6) Change some pointer members of `mozInlineSpellChecker::SpellCheckerTimeSlice` to references. r=smaug

Depends on D114099

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 7) Annotate `mozInlineSpellChecker::SpellCheckerTimeSlice` as `MOZ_STACK_CLASS`. r=smaug

Depends on D114100

Comment 12

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 8) Move `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug

Simplifies mozInlineSpellChecker::SpellCheckerTimeSlice::Execute.

Depends on D114101

Comment 13

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 9) Declare `mozInlineSpellChecker::ShouldSpellCheckNode` `static`. r=smaug

Depends on D114102

Comment 14

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 10) Factor `ShouldSpellCheckRange` out. r=smaug

Depends on D114103

Comment 15

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 11) Remove unnecessary block scope in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`. r=smaug

Depends on D114104

Comment 16

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Will add :smaug as reviewer as soon as he's back from vacation.

Comment 17

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: WIP: Bug 1708422: part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`

Comment 18

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`. r=smaug

Comment 19

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug

Depends on D114331

Comment 20

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug

Depends on D114332

Comment 21

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 15) Update documentation of `Selection::GetRangesForInterval`. r=smaug

Depends on D114333

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91483132916f
part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug

Comment 23

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/91483132916f

Comment 24

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug

Depends on D114334

Comment 25

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug

Depends on D115352

Comment 26

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug

Hides details.

Depends on D115366

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df784a865e38
part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/54be73d69bf4
part 5) Surround statements in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute` with curly braces. r=smaug
https://hg.mozilla.org/integration/autoland/rev/7d0b7c8641ad
part 6) Change some pointer members of `mozInlineSpellChecker::SpellCheckerTimeSlice` to references. r=smaug
https://hg.mozilla.org/integration/autoland/rev/554e8a60c7ed
part 7) Annotate `mozInlineSpellChecker::SpellCheckerTimeSlice` as `MOZ_STACK_CLASS`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/936a9c00a51c
part 8) Move `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/0e8fbb1c3f35
part 9) Declare `mozInlineSpellChecker::ShouldSpellCheckNode` `static`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/9571e1990895
part 10) Factor `ShouldSpellCheckRange` out. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2122e4d660c6
part 11) Remove unnecessary block scope in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/dfd6996a67fa
part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/5a0ccf5c7dc4
part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/101827a7d1a4
part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/3495c7bfdcee
part 15) Update documentation of `Selection::GetRangesForInterval`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e5f57b354d88
part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/06ca014ca2bf
part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug

Comment 28

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug

Clearer and helps to simplify its caller.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b803787c11
part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug

Comment 30

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug

Clearer.

Comment 31

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1708422: part 21) Reduce scope of `erv` variable in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug

Depends on D115686

Comment 32

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/df784a865e38
https://hg.mozilla.org/mozilla-central/rev/54be73d69bf4
https://hg.mozilla.org/mozilla-central/rev/7d0b7c8641ad
https://hg.mozilla.org/mozilla-central/rev/554e8a60c7ed
https://hg.mozilla.org/mozilla-central/rev/936a9c00a51c
https://hg.mozilla.org/mozilla-central/rev/0e8fbb1c3f35
https://hg.mozilla.org/mozilla-central/rev/9571e1990895
https://hg.mozilla.org/mozilla-central/rev/2122e4d660c6
https://hg.mozilla.org/mozilla-central/rev/dfd6996a67fa
https://hg.mozilla.org/mozilla-central/rev/5a0ccf5c7dc4
https://hg.mozilla.org/mozilla-central/rev/101827a7d1a4
https://hg.mozilla.org/mozilla-central/rev/3495c7bfdcee
https://hg.mozilla.org/mozilla-central/rev/e5f57b354d88
https://hg.mozilla.org/mozilla-central/rev/06ca014ca2bf
https://hg.mozilla.org/mozilla-central/rev/82b803787c11

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d997e78d89f5
part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4a6ddb682476
part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/cc8afd010568
part 21) Reduce scope of `erv` variable in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug

Comment 34

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d997e78d89f5
https://hg.mozilla.org/mozilla-central/rev/4a6ddb682476
https://hg.mozilla.org/mozilla-central/rev/cc8afd010568