1708424 - [Proton] Dropdown focus highlight (Bookmark panel) cuts off the Location underline

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Affected versions

• 89.0b5
• 90.0a1 (2021-04-28)

Affected platforms

• Windows 10
• Ubuntu 18

Steps to reproduce

1. Open any website
2. Click the Star icon inside the URL bar
3. Navigate the Bookmark panel using the Tab key to the Location field
4. Observe the Location label

Expected result

• The Location label and the underline text-decorative are visible

Actual result

• The focus highlight cuts off the underline text-decorative from the Location label

Regression range

• Introduced with the Proton changes, as a consequence of the highlight styling for dropdowns

Comment 1

[Emma Malysz]

Attachment: Bug 1708424, increase spacing beneath labels in edit bookmark panel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4785327a69e
increase spacing beneath labels in edit bookmark panel r=mconley

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c4785327a69e

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Anca Soncutean, Desktop QA]

Verified fixed with 91.0a1 ((2021-06-03) and 90.0b3 on Windows 10 and Ubuntu 18.04.