Closed Bug 1708424 Opened 2 months ago Closed 1 month ago

[Proton] Dropdown focus highlight (Bookmark panel) cuts off the Location underline

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: Anca, Assigned: emalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-door-hangers] [priority:2a])

Attachments

(2 files)

Attached image screencast issue.gif

Affected versions

  • 89.0b5
  • 90.0a1 (2021-04-28)

Affected platforms

  • Windows 10
  • Ubuntu 18

Steps to reproduce

  1. Open any website
  2. Click the Star icon inside the URL bar
  3. Navigate the Bookmark panel using the Tab key to the Location field
  4. Observe the Location label

Expected result

  • The Location label and the underline text-decorative are visible

Actual result

  • The focus highlight cuts off the underline text-decorative from the Location label

Regression range

  • Introduced with the Proton changes, as a consequence of the highlight styling for dropdowns
Has STR: --- → yes
Priority: -- → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2b]
Whiteboard: [proton-door-hangers] [priority:2b] → [proton-door-hangers] [priority:2a]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4785327a69e
increase spacing beneath labels in edit bookmark panel r=mconley
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emalysz)
Flags: needinfo?(emalysz)
Flags: qe-verify+

Verified fixed with 91.0a1 ((2021-06-03) and 90.0b3 on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.