1708454 - dom/media/mediasink/AudioDecoderInputTrack.cpp:336:17: error: ?MakeScopeExit? was not declared in this scope

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Solaris build fails with:

 9:53.71 /builds/psumbera/mozilla-central-build/dom/media/mediasink/AudioDecoderInputTrack.cpp: In member function ?virtual void mozilla::AudioDecoderInputTrack::ProcessInput(mozilla::GraphTime, mozilla::GraphTime, uint32_t)?:
 9:53.71 /builds/psumbera/mozilla-central-build/dom/media/mediasink/AudioDecoderInputTrack.cpp:336:17: error: ?MakeScopeExit? was not declared in this scope
 9:53.71   336 |   auto notify = MakeScopeExit([this, &filledDuration] {
 9:53.71       |                 ^~~~~~~~~~~~~

The first bad revision is:
changeset: 577921:5ac05c27c39b
user: alwu <[e-mail]>
date: Wed Apr 28 18:37:20 2021 -0700
description:
Bug 1695265 - part1 : implement AudioDecoderInputTrack. r=pehrsons

Comment 1

[Paul Adenot (:padenot)]

Alastor, a simple missing #include.

Comment 2

[Alastor Wu [:alwu]]

Thank you! Hmm I wonder why this error didn't show up on the try server while I was testing...

Comment 3

[Paul Adenot (:padenot)]

Solaris build fails with [...]

Solaris is not a tier-1 or tier-2 platform so it's not on Try.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1708454 - add missing include header. r?padenot

Comment 5

[Petr Sumbera]

Yes, this change fixes the issue!

I still wonder in which Solaris build is different that we see quite a few problems with this header file.

Comment 6

[Dan Horák]

And it also fixes my Linux/ppc64le build failure.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e338aaaa8ef
add missing include header. r=padenot

Comment 8

[Paul Adenot (:padenot)]

Thanks for the confirmation folks.

Alastor, I'm landing your three patches that fix various things so that it hits the tree quickly for downstream users.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1695265

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8e338aaaa8ef