Closed Bug 1708492 Opened 3 years ago Closed 3 years ago

Update FxA avatar icons

Categories

(Firefox :: Theme, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox89 + fixed
firefox90 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [proton-uplift])

Attachments

(1 file)

browser/themes/shared/fxa/avatar.svg
browser/themes/shared/fxa/avatar-empty.svg

browser/themes/shared/fxa/avatar-color.svg is marked as "No changes planned" on the spreadsheet, but updating it should just be a matter of applying the linear-gradient from the current avatar-color.svg to the new avatar.svg.

Whiteboard: [proton-icons]
Summary: Update FxA icons → Update FxA avatar icons

(In reply to Harry Twyford [:harry] from comment #0)

browser/themes/shared/fxa/avatar-color.svg is marked as "No changes planned" on the spreadsheet, but updating it should just be a matter of applying the linear-gradient from the current avatar-color.svg to the new avatar.svg.

I spoke to UX and they said the new avatar icons aren't designed to be shown at the sizes where avatar-color.svg is shown. I'll leave that icon be. With that said, I developed new versions of the colourful icon. We could use part of this when eventually replacing avatar-color.svg:

Light mode

<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
    <linearGradient id="a" x1="0" x2="16" y1="16" y2="0" gradientUnits="userSpaceOnUse">
      <stop offset=".26" stop-color="#AB71FF"/>
      <stop offset=".96" stop-color="#0250BB"/>
    </linearGradient>
  <circle cx="8" cy="8" fill="#F9F9FB" r="6.5"/>
  <path d="M8.5 1a7.5 7.5 0 1 0 0 15 7.5 7.5 0 0 0 0-15zm0 3.5a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5zm0 9.75c-1.912 0-3.571-1.038-4.489-2.569A1.993 1.993 0 0 1 5.505 11l5.99 0c.596 0 1.126.267 1.494.681-.918 1.531-2.577 2.569-4.489 2.569z" fill="url(#a)"/>
</svg>

Dark mode

<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<linearGradient id="a" x1="0" x2="16" y1="16" y2="0" gradientUnits="userSpaceOnUse">
      <stop offset=".26" stop-color="#CB9EFF"/>
      <stop offset=".96" stop-color="#00DDFF"/>
    </linearGradient>
  <circle cx="8" cy="8" fill="#2B2A33" r="6.5"/>
  <path d="M8.5 1a7.5 7.5 0 1 0 0 15 7.5 7.5 0 0 0 0-15zm0 3.5a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5zm0 9.75c-1.912 0-3.571-1.038-4.489-2.569A1.993 1.993 0 0 1 5.505 11l5.99 0c.596 0 1.126.267 1.494.681-.918 1.531-2.577 2.569-4.489 2.569z" fill="url(#a)"/>
</svg>

[Tracking Requested - why for this release]:
Proton icons.

I'll request uplift tomorrow after I've verified the fix in Nightly.

Flags: needinfo?(htwyford)

avatar-empty.svg appears in the FxA toolbarbutton when not signed in. In a fresh profile, open the customize window. It'll be in the toolbar.
avatar.svg appears in the Firefox Monitor section of about:protections.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219312 [details]
Bug 1708492 - Update FxA avatar icons. r?sfoster,mconley

Beta/Release Uplift Approval Request

  • User impact if declined: Proton icons will be missing.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only replaces the contents of two SVGs. New icons verified in Nightly.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9219312 - Flags: approval-mozilla-beta?
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]

Comment on attachment 9219312 [details]
Bug 1708492 - Update FxA avatar icons. r?sfoster,mconley

Approved for 89 beta 7, thanks.

Attachment #9219312 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: