Closed
Bug 1708501
Opened 4 years ago
Closed 4 years ago
Compact the FxA menuitem when in the signed-out state
Categories
(Firefox :: Menus, task)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-hamburger-menu] [proton-uplift])
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
We did the signed-in state in bug 1708222, but missed the signed out state. This bug covers that case.
| Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mconley
| Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Attachment #9219277 -
Attachment description: WIP: Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz! → Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c1e123e8b04
Compact the AppMenu FxA menuitem when signed out. r=emalysz
| Assignee | ||
Comment 3•4 years ago
|
||
Comment on attachment 9219277 [details]
Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very minimal, well understood CSS change that impacts only a single menu item in the AppMenu (the FxA item when in the signed-out state).
- String changes made/needed: None.
Attachment #9219277 -
Flags: approval-mozilla-beta?
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Updated•4 years ago
|
status-firefox89:
--- → affected
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu] [proton-uplift]
Comment 5•4 years ago
|
||
Comment on attachment 9219277 [details]
Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!
Approved for 89 beta 7, thanks.
Attachment #9219277 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•4 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•