Closed Bug 1708501 Opened 4 years ago Closed 4 years ago

Compact the FxA menuitem when in the signed-out state

Categories

(Firefox :: Menus, task)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-hamburger-menu] [proton-uplift])

Attachments

(1 file)

We did the signed-in state in bug 1708222, but missed the signed out state. This bug covers that case.

Assignee: nobody → mconley
Attachment #9219277 - Attachment description: WIP: Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz! → Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c1e123e8b04 Compact the AppMenu FxA menuitem when signed out. r=emalysz

Comment on attachment 9219277 [details]
Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very minimal, well understood CSS change that impacts only a single menu item in the AppMenu (the FxA item when in the signed-out state).
  • String changes made/needed: None.
Attachment #9219277 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu] [proton-uplift]

Comment on attachment 9219277 [details]
Bug 1708501 - Compact the AppMenu FxA menuitem when signed out. r?emalysz!

Approved for 89 beta 7, thanks.

Attachment #9219277 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: