1708553 - Pocket section in German is showing English topics

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

I noticed this regression in bug 1703678 and decided to file it as a followup.

It caused a regression where topics appear in the Navigation component under newtab Pocket story section, and it should not.

Should be an easy fix, already have something in the works.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1708553 - Fix newtab Pocket section in German is showing English topics

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Issue where English content might appear in non English browsers.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 9219353 [details]
Bug 1708553 - Fix newtab Pocket section in German is showing English topics

Beta/Release Uplift Approval Request

• User impact if declined: Issue where English content might appear in non English browsers.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Using steps here: https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/v2-system-addon/geo_locale.html#setting-custom-geo-locale-and-update-channels

2. Setup a German language browser with DE region, as per the instructions above.
   Expected: Newtab should have a privacy link in the bottom corner of the Pocket section, but no English topics.

• List of other uplifts needed: Bug 1703678
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1 liner condition.
• String changes made/needed: none

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/267f24e58da3
Fix newtab Pocket section in German is showing English topics r=amy

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/267f24e58da3

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9219353 [details]
Bug 1708553 - Fix newtab Pocket section in German is showing English topics

Approved for 89 beta 7, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1071973e1ac

Comment 8

[Robert Martin [:romartin], Ecosystem QA]

I have verified that only the privacy link is displayed in the Pocket section using Firefox Nightly 90.0a1 (Build ID: 20210503214210) and Firefox Beta 89.0b7 (Build ID: 20210502185943) on Windows 10 x64, macOS 11.3, and Ubuntu Linux 20.04 x64 by doing the following:

• Setting the browser.search.region pref value to DE.
• Having the region set to DE automatically by using a VPN software.