1708562 - mochitest profiling does not work on browser_ext_browserAction_contextMenu.js - "No profile was found at the profile path"

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Markus Stange [:mstange]]

I'm on mozilla-central revision d9e30da70def.

Steps to reproduce:

1. ./mach mochitest browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js --profiler

Expected results:
The profiler opens after the test.

Actual results:

Browser Chrome Test Summary
	Passed: 212
	Failed: 0
	Todo: 0
	Mode: e10s
*** End BrowserChrome Test Results ***
 0:22.21 profiler INFO Shutdown performance profiling was enabled
 0:22.21 profiler INFO Profile saved locally to: /var/folders/tr/8xb9hnk11xv3kp2wxnzd1t3w0000gn/T/tmpiobii9e8/mochitest-profile.json
 0:22.21 profiler INFO Symbolicating the performance profile... This could take a couple of minutes.
 0:22.22 profiler ERROR Encountered an exception during profile symbolication
 0:22.22 profiler ERROR [Errno 2] No such file or directory: '/var/folders/tr/8xb9hnk11xv3kp2wxnzd1t3w0000gn/T/tmpiobii9e8/mochitest-profile.json'
 0:22.22 profiler ERROR No profile was found at the profile path, cannot launch profiler.firefox.com.
 0:22.22 INFO Buffered messages finished
 0:22.22 SUITE_END

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1708562 - avoid stopping the profiler on customizationchange events when profiling mochitests, r=mstange.

Comment 2

[Florian Quèze [:florian]]

(In reply to Markus Stange [:mstange] from comment #0)

I'm on mozilla-central revision d9e30da70def.

Steps to reproduce:

1. ./mach mochitest browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js --profiler

Expected results:
The profiler opens after the test.

Not a regression, it's just that customizing the browser toolbar causes the profiler to stop (I gave you a patch for this to push in your try pushes; I submitted it here for review). Here's a profile of the browser_ext_browserAction_contextMenu.js test: https://share.firefox.dev/3aQ97hQ

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7addaf5b3a61
avoid stopping the profiler on customizationchange events when profiling mochitests, r=mstange,julienw.

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7addaf5b3a61