Closed Bug 1708588 Opened 2 years ago Closed 2 years ago

Update the document and page orientation icons

Categories

(Toolkit :: Themes, enhancement)

Product:
Toolkit
Component:
Themes
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: sfoster, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [proton-uplift])

Attachments

(1 file)

Bug 1708588 - Add page-portrait.svg and page-landscape.svg to shared toolkit icons; use these from the print UI, and instead of document.svg. r?harry
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

We have new portrait and landscape icons for the page orientation controls. See https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE for details and where to get the new files.

Blocks: proton-icons

Moving component, as it looks like it makes sense to just update document.svg while I'm at it.

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Component: Printing → Themes
Summary: Update the page orientation icons → Update the document and page orientation icons

Print UI (default/tab-modal print UI only, no changes to system print UI)

The portrait icon is used in the print settings sidebar as the icon for the PDF printer, and portrait and landscape icons for the page orientation picker.

URLBar/Control center

The portrait icon (formerly document.svg) is used as the icon in the URL bar (where the lock would normally appear) for file:// URIs, and in the footer of the panel opened by clicking that icon.

Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5ee8b31d9ce
Add page-portrait.svg and page-landscape.svg to shared toolkit icons; use these from the print UI, and instead of document.svg. r=harry,desktop-theme-reviewers

https://hg.mozilla.org/mozilla-central/rev/a5ee8b31d9ce

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219411 [details]
Bug 1708588 - Add page-portrait.svg and page-landscape.svg to shared toolkit icons; use these from the print UI, and instead of document.svg. r?harry

Beta/Release Uplift Approval Request

  • User impact if declined: Inconsistent icon style
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment #3.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple icon swap in relatively low visibility UI
  • String changes made/needed: None
Attachment #9219411 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]

Comment on attachment 9219411 [details]
Bug 1708588 - Add page-portrait.svg and page-landscape.svg to shared toolkit icons; use these from the print UI, and instead of document.svg. r?harry

Low risk icon swap for Proton, uplift approved for 89 beta 8, thanks.

Attachment #9219411 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified that the icons mentioned in Comment 3 are implemented and working as expected (verified with a txt sample file) on Firefox 89.0b9 and Firefox 90.0a1 (2021-05-06). Tests were performed on macOS 10.15.7, Windows 10 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
status-firefox90: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.