1708596 - Excessive flickering in the Today Pane

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

When just about anything happens in the calendar, the Today Pane agenda view refreshes everything, even calendars unrelated to what happened. I made this worse with bug 1691885 but also made it slightly easier to fix with bug 1700047. In this bug I'm going to try to restrict refreshing to only those calendars that need it.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1708596 - In the Today Pane, refresh only calendars that require refreshing. r?mkmelin

With this patch, we only refresh the calendar that changed.

I've also renamed some functions from 'deleteFoo' to 'removeFoo' as that's a more appropriate verb. And I've removed a redundant update when a calendar colour changes, as that's now handled elsewhere.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/367a5b568b23
In the Today Pane, refresh only calendars that require refreshing. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9219767 [details]
Bug 1708596 - In the Today Pane, refresh only calendars that require refreshing. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1691885, sort of
User impact if declined: Today Pane reloads everything any time an event changes
Testing completed (on c-c, etc.): just landed, I'd want it in Daily for at least a week just in case, so targeting beta 4?
Risk to taking this patch (and alternatives if risky): a small possibility there are edge cases I've missed, but they should only result in bad display of data that can be corrected

Comment 4

[Wayne Mery (:wsmwk)]

Is 78 unaffected?

Comment 5

[Geoff Lankow (:darktrojan)]

Yes. Actually no, it is affected, but it's much worse on beta. I don't intend to uplift this to 78.

Comment 6

[Wayne Mery (:wsmwk)]

Thanks for the assessment

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9219767 [details]
Bug 1708596 - In the Today Pane, refresh only calendars that require refreshing. r?mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/83dab665fa62