1708729 - Port 65535 can no longer be unblocked

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Kestrel]

STR:

1. Create preference string network.security.ports.banned.override = "65535"
2. Visit localhost:65535.

Expected:

"Unable to connect"

Actual:

"This address is restricted"

Port 65535 is a valid port number and it should be possible to unblock it.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6e0b8e5132681674e06cab2a94727a3e9e012f2a&tochange=774f4e003006bd1f211b1848cccbb00d89fe64d1

Regressed by Bug 1698503.

Comment 1

[Catharsis]

I am experiencing this in ESR 78.10.0

I have tried it individually and with range "1-65535"

Comment 2

[Kestrel]

Confirmed 78 is also affected.

Comment 3

[Frederik Braun [:freddy]]

Right. I the disallow check shouldn't be greater-than-or-equals uint16-max, but only "greater than".
https://searchfox.org/mozilla-central/source/netwerk/base/nsIOService.cpp#1412-1415

I suppose this could be a good first bug.

Comment 5

[Robert Longson [:longsonr]]

Attachment: Bug 1708729 - Allow port 65535 to be unblocked

Comment 6

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f64f08c43d2820f6f086fb423e87becca386334c

Comment 7

[Robert Longson [:longsonr]]

I tried creating a test but I'm not sure I'm running it. It seems to be an xpcshell test but I can't find it in the logs.

I tried removing the fix and running the same tests but they all still pass (or maybe they aren't even being run).

So is the test being run in comment 6 and if so why does it always pass?

Comment 8

[Frederik Braun [:freddy]]

Please see my response in phabricator.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:longsonr, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11fde2629eac
Allow port 65535 to be unblocked r=necko-reviewers,freddyb,valentin

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/11fde2629eac

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to ESR78 also?

Comment 13

[Robert Longson [:longsonr]]

I really don't know how critical it is. One duplicate doesn't seem much so if you ask me then, no I wouldn't do it.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Fine by me, the fix will ship in ESR91 going out soon in that case.