Closed Bug 1708729 Opened 1 year ago Closed 11 months ago

Port 65535 can no longer be unblocked

Categories

(Core :: Networking, defect, P3)

Firefox 88
defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: ke5trel, Assigned: longsonr)

References

(Regression)

Details

(Keywords: good-first-bug, regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

STR:

  1. Create preference string network.security.ports.banned.override = "65535"
  2. Visit localhost:65535.

Expected:

"Unable to connect"

Actual:

"This address is restricted"

Port 65535 is a valid port number and it should be possible to unblock it.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6e0b8e5132681674e06cab2a94727a3e9e012f2a&tochange=774f4e003006bd1f211b1848cccbb00d89fe64d1

Regressed by Bug 1698503.

Flags: needinfo?(fbraun)

I am experiencing this in ESR 78.10.0

I have tried it individually and with range "1-65535"

Confirmed 78 is also affected.

Right. I the disallow check shouldn't be greater-than-or-equals uint16-max, but only "greater than".
https://searchfox.org/mozilla-central/source/netwerk/base/nsIOService.cpp#1412-1415

I suppose this could be a good first bug.

Flags: needinfo?(fbraun)
Severity: -- → S3
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [necko-triaged]
Duplicate of this bug: 1710196
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Has Regression Range: --- → yes

I tried creating a test but I'm not sure I'm running it. It seems to be an xpcshell test but I can't find it in the logs.

I tried removing the fix and running the same tests but they all still pass (or maybe they aren't even being run).

So is the test being run in comment 6 and if so why does it always pass?

Flags: needinfo?(fbraun)

Please see my response in phabricator.

Flags: needinfo?(fbraun)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:longsonr, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(longsonr)
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(longsonr)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/11fde2629eac
Allow port 65535 to be unblocked r=necko-reviewers,freddyb,valentin
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Is this something we should consider uplifting to ESR78 also?

Flags: needinfo?(longsonr)

I really don't know how critical it is. One duplicate doesn't seem much so if you ask me then, no I wouldn't do it.

Flags: needinfo?(longsonr)

Fine by me, the fix will ship in ESR91 going out soon in that case.

You need to log in before you can comment on or make changes to this bug.