Closed Bug 1708749 Opened 4 years ago Closed 4 years ago

Additional proton styling to close button and chevron in site permissions panel

Categories

(Firefox :: Site Permissions, enhancement, P2)

Product:
Firefox
Component:
Site Permissions
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: emmamalysz, Assigned: emmamalysz)

References

Details

(Whiteboard: [proton-door-hangers] [priority:2a] [proton-uplift])

Attachments

(1 file)

Bug 1708749, add padding for the permission panel's close and chevron icons
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

For the permissions panel, UX has requested:

  1. The close icons have additional padding to the right (8px)
  2. The dropdown chevron is the same size as the close icon and is right aligned
Severity: -- → N/A
Priority: -- → P1

Marking as P2 since for Proton P1 bugs imply release blockers.

Priority: P1 → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers] [priority:2a]
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1cafed25ba03 add padding for the permission panel's close and chevron icons r=mconley

https://hg.mozilla.org/mozilla-central/rev/1cafed25ba03

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

This looks very low risk, Emma can you request the uplift to beta? Thanks

Flags: needinfo?(emalysz)

Comment on attachment 9219576 [details]
Bug 1708749, add padding for the permission panel's close and chevron icons

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No strings, just an icon fix
  • String changes made/needed: n/a
Flags: needinfo?(emalysz)
Attachment #9219576 - Flags: approval-mozilla-beta?

Comment on attachment 9219576 [details]
Bug 1708749, add padding for the permission panel's close and chevron icons

p2a, approved for 89 beta 9, thanks.

Attachment #9219576 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers] [priority:2a] → [proton-door-hangers] [priority:2a] [proton-uplift]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: