1708855 - Some cleanups to ComputeTransformForScrollThumb

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Botond Ballo [:botond]]

In bug 1700169, I'm going to be extending our code for computing async transforms for scroll thumbs to also include a transform for overscrolling.

In preparation for that, I'd like to clean up that code a bit in a way that makes it easier to extend.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Move the implementation of ComputeTransformForScrollThumb into its own file. r=tnikkel

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Move the implementation of ComputeTransformForScrollThumb into an instance method of a class. r=tnikkel

This allows us to factor out parts of the computation into their own
functions without having to pass too many things around as arguments.

Depends on D114159

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Give Axis a few more accessor methods. r=tnikkel

Depends on D114160

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Promote a few local variables in AsyncScrollThumbTransformer::ComputeTransform() to fields. r=tnikkel

Depends on D114161

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Use Axis to avoid code repetition in AsyncScrollThumbTransformer. r=tnikkel

Depends on D114162

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1708855 - Remove Axis::GetScaleForAxis(). r=tnikkel

It was duplicating the method GetAxisScale().

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69211b49b74e
Move the implementation of ComputeTransformForScrollThumb into its own file. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/25d2c59827d5
Move the implementation of ComputeTransformForScrollThumb into an instance method of a class. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/6c0ee6dc6175
Give Axis a few more accessor methods. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/66761d87448d
Promote a few local variables in AsyncScrollThumbTransformer::ComputeTransform() to fields. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/f0133ba38ffc
Use Axis to avoid code repetition in AsyncScrollThumbTransformer. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/d69918d6f325
Remove Axis::GetScaleForAxis(). r=tnikkel

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/69211b49b74e
https://hg.mozilla.org/mozilla-central/rev/25d2c59827d5
https://hg.mozilla.org/mozilla-central/rev/6c0ee6dc6175
https://hg.mozilla.org/mozilla-central/rev/66761d87448d
https://hg.mozilla.org/mozilla-central/rev/f0133ba38ffc
https://hg.mozilla.org/mozilla-central/rev/d69918d6f325