1708879 - (Proton) (regression) the padlock icon position in the address bar is not stable for secure and mixed content

Status: NEW

(Firefox :: Address Bar, defect, P2)

Description

[Sören Hentzschel]

Attachment: screencast

If you switch between tabs with secure and mixed content the position of the padlock icon in the address bar changes. This is a very noticeable regression in the user experience. I attached a screencast that shows both Firefox Nightly and Firefox 88 in comparison.

Comment 1

[Alexandru Trif, QA [:atrif]]

Hello! Attaching regression range made on Windows 10x64 using security.mixed_content.upgrade_display_content:false
Last good revision: bfc4564739af31f55d7c7370af45551b35722e0c
First bad revision: ef291044883cd93a7810d9466c48993ff4da974a
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bfc4564739af31f55d7c7370af45551b35722e0c&tochange=ef291044883cd93a7810d9466c48993ff4da974a

Comment 2

[Sam Foster [:sfoster] (he/him)]

Yeah the new icon doesnt treat the warning state as a badge/overlay, it centers the lock+triangle in the 16x16 grid. I'll need to look to see if we use that anywhere else. In another context it might be important for the whole to remain centered. If not, this might be something we can fix.

Comment 3

[Drew Willcoxon :adw]

Still happens on Nightly.

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Drew Willcoxon :adw from comment #3)

Still happens on Nightly.

Yeah this is by design currently. The question is if we want to change the design and what other ramifications that might have.