Closed Bug 1708935 Opened 4 years ago Closed 4 years ago

Permanent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P5)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox88 unaffected, firefox89 unaffected, firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: glandium)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files)

Bug 1708935 - Run clippy sequentially.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1708935 - Don't run clippy on crates that don't build on Linux.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=338424542&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Bvc13MCaQTGaNd7fXAHYDQ/runs/0/artifacts/public/logs/live_backing.log

task 2021-05-01T22:24:11.818Z] 22:24:11.811 clippy (62) | clippy output: b'    Checking stable_deref_trait v1.2.0'
[task 2021-05-01T22:24:11.818Z] 22:24:11.812 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:11.818Z] 22:24:11.812 clippy (62) | clippy output: b'    Checking servo_arc v0.1.1 (/builds/worker/checkouts/gecko/servo/components/servo_arc)'
[task 2021-05-01T22:24:11.818Z] 22:24:11.813 clippy (62) | Skipping the summary line {'rendered': 'warning: 9 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'warning', 'message': '9 warnings emitted', 'spans': []} for file /builds/worker/checkouts/gecko/servo/components/servo_arc/lib.rs
[task 2021-05-01T22:24:11.818Z] 22:24:11.813 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:11.819Z] 22:24:11.813 clippy (62) | clippy output: b'    Finished dev [unoptimized + debuginfo] target(s) in 1.21s'
[task 2021-05-01T22:24:11.819Z] 22:24:11.813 clippy (62) | Path = /builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows
[task 2021-05-01T22:24:11.819Z] 22:24:11.813 clippy (62) | Path translated to = /builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows/Cargo.toml
[task 2021-05-01T22:24:11.819Z] 22:24:11.813 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows/Cargo.toml']
[task 2021-05-01T22:24:11.864Z] 22:24:11.863 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clippy', '--message-format=json', '--manifest-path', '/builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows/Cargo.toml']
[task 2021-05-01T22:24:29.936Z] 22:24:29.935 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows/Cargo.toml']
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'    Updating git repository `https://github.com/rust-windowing/android-rs-glue.git`'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'    Updating git repository `https://github.com/jrmuizel/winit`'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'    Updating git repository `https://github.com/servo/osmesa-src`'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b' Downloading crates ...'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'  Downloaded cc v1.0.50'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'   Compiling cc v1.0.50'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | clippy output: b'   Compiling compositor-windows v0.1.0 (/builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows)'
[task 2021-05-01T22:24:29.990Z] 22:24:29.987 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'The following warnings were emitted during compilation:'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'warning:  #include <windows.h>'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'warning:           ^~~~~~~~~~~'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'warning: compilation terminated.'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'error: failed to run custom build command for `compositor-windows v0.1.0 (/builds/worker/checkouts/gecko/gfx/wr/example-compositor/compositor-windows)`'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'Caused by:'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b"  process didn't exit successfully: `/builds/worker/checkouts/gecko/gfx/wr/target/debug/build/compositor-windows-63fd521760c801c9/build-script-build` (exit code: 1)"
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | clippy output: b'  --- stdout'
[task 2021-05-01T22:24:29.990Z] 22:24:29.988 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | clippy output: b'  TARGET = Some("x86_64-unknown-linux-gnu")'
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | clippy output: b'  OPT_LEVEL = Some("0")'
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | clippy output: b'  HOST = Some("x86_64-unknown-linux-gnu")'
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | clippy output: b'  CC_x86_64-unknown-linux-gnu = None'
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.990Z] 22:24:29.989 clippy (62) | clippy output: b'  CC_x86_64_unknown_linux_gnu = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  HOST_CC = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  CC = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  CFLAGS_x86_64-unknown-linux-gnu = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  CFLAGS_x86_64_unknown_linux_gnu = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  HOST_CFLAGS = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  CFLAGS = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | clippy output: b'  CRATE_CC_NO_DEFAULTS = None'
[task 2021-05-01T22:24:29.991Z] 22:24:29.989 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  DEBUG = Some("true")'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "../../../angle/checkout/include" "-Wall" "-Wextra" "-o" "/builds/worker/checkouts/gecko/gfx/wr/target/debug/build/compositor-windows-65e2326b0417a0a4/out/src/lib.o" "-c" "src/lib.cpp"'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  cargo:warning=src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  cargo:warning= #include <windows.h>'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | clippy output: b'  cargo:warning=          ^~~~~~~~~~~'
[task 2021-05-01T22:24:29.991Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | clippy output: b'  cargo:warning=compilation terminated.'
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | clippy output: b'  exit code: 1'
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | clippy output: b'  --- stderr'
[task 2021-05-01T22:24:29.992Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.993Z] 22:24:29.990 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.993Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.993Z] 22:24:29.990 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.993Z] 22:24:29.990 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | clippy output: b'  error occurred: Command "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "../../../angle/checkout/include" "-Wall" "-Wextra" "-o" "/builds/worker/checkouts/gecko/gfx/wr/target/debug/build/compositor-windows-65e2326b0417a0a4/out/src/lib.o" "-c" "src/lib.cpp" with args "cc" did not execute successfully (status code exit code: 1).'
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | clippy output: b''
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | Path = /builds/worker/checkouts/gecko/servo/components/style
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | Path translated to = /builds/worker/checkouts/gecko/servo/components/style/Cargo.toml
[task 2021-05-01T22:24:29.993Z] 22:24:29.991 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/servo/components/style/Cargo.toml']
[task 2021-05-01T22:24:30.107Z] 22:24:30.107 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clippy', '--message-format=json', '--manifest-path', '/builds/worker/checkouts/gecko/servo/components/style/Cargo.toml']
[task 2021-05-01T22:24:30.624Z] 22:24:30.624 clippy (62) | Command: ['/builds/worker/fetches/rustc/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/servo/components/style/Cargo.toml']
[task 2021-05-01T22:24:30.707Z] 22:24:30.706 clippy (62) | Could not parse the output:
[task 2021-05-01T22:24:30.707Z] 22:24:30.707 clippy (62) | clippy output: b'    Updating crates.io index'```
Flags: needinfo?(mh+mozilla)

These messages are also part of successful rust(clippy) runs.

The reason the task in comment 0 failure were failures about security/manager/ssl/osclientcerts/src/lib.rs

status-firefox88: --- → unaffected
status-firefox89: --- → unaffected
status-firefox90: --- → affected
status-firefox-esr78: --- → unaffected
Summary: Intermittent clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory' → Permanent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'

The parallel run of sequences of "clean; clippy; clean" creates race
conditions that alter the results of clippy and can mask errors.
Moreover, chances are clippy is not allowing any parallelization
anyways, because with two concurrent clippy running, one will be waiting
for the other because of cargo locking.

This turns the current intermittent failure into a permanent one.

Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mh+mozilla)
Summary: Permanent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory' → Intermittent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'
Summary: Intermittent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory' → Permanent failure lines for successful rust(clippy) tasks: clippy (62) | clippy output: b'warning: src/lib.cpp:7:10: fatal error: windows.h: No such file or directory'
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/05bea0bfc54b Run clippy sequentially. r=sylvestre https://hg.mozilla.org/integration/autoland/rev/07192cfef6c5 Don't run clippy on crates that don't build on Linux. r=sylvestre

https://hg.mozilla.org/mozilla-central/rev/05bea0bfc54b
https://hg.mozilla.org/mozilla-central/rev/07192cfef6c5

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Has Regression Range: --- → yes
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: