1709046 - Cannot disable the use of OpenPGP if no valid key is present

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

If previously an OpenPGP key was available, but now the key is no longer usable, Thunderbird will still remember that the key was configured (and try to use it), and will not provide an option to disable the OpenPGP configuration (no "None" selection).

To reproduce:

• fresh email account config
• create a new personal key
• ensure the personal key is selected in account settings
• either delete the key, or mark the key as no longer being a personal key

Actual behavior:

• account settings report that the current config uses a key (ID shown)
• there is no selection area to switch to "None"

In my opinion, the "None" selection should always be shown.
This would that the UI logic runs into scenarios that aren't predicted.

Comment 1

[Kai Engert [:KaiE:]]

As a consequence, with the key gone, and the configuration still active, the user will get failures (cannot encrypt) when saving drafts (manual or automatic).

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1709046 - when a configured key has been deleted, allow selecting None as configured key. r=kaie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e988d538ccf
when a configured key has been deleted, allow selecting None as configured key. r=kaie

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c163e207f31
adjust browser_keyWizard.js for hidden vs. collapsed. rs=bustage-fix

Comment 5

[Kai Engert [:KaiE:]]

I think this is a bad usability experience, and esr78 will be around for another 6 months, I suggest we consider some kind of minimal backport (without new strings).

Comment 6

[Kai Engert [:KaiE:]]

Attachment: 1709046-backport-esr78.patch

This is a subset of Magnus' work that works as a backport for esr78.

It contains all the changes to fix this bug, by allowing the user to select "None", and thus disabling the configured but unsuable/absent key.

It omits the explanation and new strings.

Patch contains the test fix from the separate commit.

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: invalid configuration cannot be fixed by user
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9223134 [details] [diff] [review]
1709046-backport-esr78.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.11.0:
https://hg.mozilla.org/releases/comm-esr78/rev/7fa70211e8f7