1709062 - Make printpreview_helper use a <browser> rather than depending on OS window size.

Status: RESOLVED FIXED

(Core :: Print Preview, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1709062 - Make printpreview_helper use a fixed viewport width. r=dholbert

Recently (due to probably a system upgrade) this test fails locally for
me with an exception in compareCanvases(), because the two preview
windows aren't always the same size.

This is more reliable, faster, more similar to what we actually do
in print preview, and more easily debuggable.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1709062 - Minor cleanups to nsDOMWindowUtils::CompareCanvases. r=dholbert

Warn when some of the pre-conditions fail and such, so that it's easy to
see what's going wrong without having to use a debugger.

Remove some useless null-checks (we were dealing with null arguments
anyways, and the return value is never null).

Depends on D114078

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3e98d3f836c
Make printpreview_helper use a fixed viewport width. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/b110e23dbb1a
Minor cleanups to nsDOMWindowUtils::CompareCanvases. r=dholbert

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f3e98d3f836c
https://hg.mozilla.org/mozilla-central/rev/b110e23dbb1a