1709106 - "You are securely connected to this site" overlaps the lock icon in Nightly

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

See screenshot.

Looking for regression range.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi Anshul! Do you think you'd have time to look at this?

Comment 3

[Anshul Sahai]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #2)

Hi Anshul! Do you think you'd have time to look at this?

Hi!
Sure, I can look into this.
I'm able to reproduce this on my nightly[90.0a1 (2021-05-04) (64-bit)], system is Linux Ubuntu.
Let me try resolving this.

Comment 4

[Mehmet]

Attachment: Overlapping_Issue.mov

fyi: I've reported the duplicate bug 1709100 for macOS. And I am still seeing it in Nightly 90.0a1 (2021-05-03) (64-Bit). A screenrecording is attached. Thanks.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Okay, thank you. Adding for 90 tracking just so that we don't lose track of this.

[Tracking Requested - why for this release]:

This is a pretty obvious visual glitch in one of our primary panels.

Comment 6

[Eiichi]

Attachment: Screenshot

This issue occurs not only secure connection but also insecure connection.
See screenshot.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Hi Anshul,

Any headway with this? I suggest if this doesn't look straight-forward, that we back out the regressor (bug 1575080) in the next day or so.

Comment 11

[Anshul Sahai]

Attachment: Bug 1709106-Making changes so that "You are securely connected to this site" doesn't overlap the lock icon. r=mconley,pbz

Comment 12

[Anshul Sahai]

Hey Mike!
Do you think this solves the issue? As much as I can tell, this solves it and doesn't override any other feature. What do you think?

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Thanks! Reviewed - I think I have a question for pbz about the security-view class: https://phabricator.services.mozilla.com/D114470#3718070

Comment 14

[Paul Zühlcke [:pbz]]

See inline reply

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dba7c93da55
Making changes so that "You are securely connected to this site" doesn't overlap the lock icon. r=mconley

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8dba7c93da55

Comment 20

[Giorgia Nichita, Release Desktop QA]

I have reproduced the issue on an affected Nightly build 90.0a1 (2021-05-03)
The fix was verified on 90.0b2 (2021-06-01). Tests were performed on Ubuntu 20.04, Windows 10 and macOS 10.15. Thanks!