1709157 - Use a default button again in the protocol handling permission and choosing dialogs

Status: RESOLVED WONTFIX

(Toolkit Graveyard :: Notifications and Alerts, enhancement, P3)

Description

[Marcela (Please NI request to Brindusa Tot)]

Attachment: image (6).png

[Affected platforms]:
Platforms: Windows 7, Windows 10

[Steps to reproduce]:

1. Launch the Firefox Browser and reach a zoom meeting
2. Click the Launch meeting button

[Expected result]:
The "Allow this site to open zoommtg link?" modal dialog is displayed according to the new Proton design. The "Always Allow url to open links" checkbox is displayed. The Choose Application and Cancel buttons are properly displayed according to the new Proton design.

[Actual result]:
The Choose Application button is not properly displayed according to the new Proton design.

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Attachment: not blue.webm

Comment 2

[Marcela (Please NI request to Brindusa Tot)]

Attachment: 20210503_162110.jpg

Comment 3

[:Gijs (he/him)]

This isn't really a styling problem per se - the styling reflects the fact that these dialogs don't have default buttons. Not using default buttons was a deliberate security-based choice that was first made in bug 1552627 because opening external applications isn't necessarily safe. We had a slew of bugs filed around clickjacking or similar methods taking advantage of users, especially by making them open IE or other builtin Windows applications with which the attacker could then exploit vulnerabilities that weren't present in Firefox.

I'm open to reconsidering this but we should make a conscious decision around it. Paul, Dan, thoughts?

Comment 4

[Daniel Veditz [:dveditz]]

The dialogs should stay without defaults. If you make "Cancel" an explicit default people will get mad.

Comment 5

[Paul Zühlcke [:pbz]]

I agree with Dan here. I remember that we had a discussion around default buttons and we decided to not default to "cancel", because it's not an established pattern in Firefox.

Comment 6

[Romain Testard [:RT]]

Agreed here, marking as "Won't fix"