170924 - Preview sound should be "listen" or play

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Henrik Gemal]

In the prefs for mail sound we current have a button named "Preview". Preview a
sound. Why not label it for what it actually does. "Listen"

20020924

Comment 1

[Malcolm Rowe]

'Listen' is a bad choice because it changes the object of the sentence from the 
sound, to the user.

e.g., You don't 'Listen' (verb) a sound (object), you (object) listen *to* 
(verb) a sound.

Generally, action should relate directly to the object, so 'Preview' (verb) 
the 'sound' (object) works ok from that point of view.

'Play' would be an less-ambigous alternative, though.

Comment 2

[Alex Bishop]

I like 'Play'.

Comment 3

[Lasse Marøen]

How about a graphic button instead? The 'play' arrow has to be one of the most
easily recognized symbols, and it would also mean one less word to translate.
Windows has this for previewing system sounds.

Comment 4

[Wayne Mery (:wsmwk)]

does 3 votes for play morph the bug to "play"? :)

Comment 5

[Patrick]

Henrik, are you still seeing this? Shredder/Thunderbird on OS X has had a button labeled "Play button for quite a while now?

Comment 6

[Wayne Mery (:wsmwk)]

WFM per comment 5

Comment 7

[Philip Chee]

Should you move this bug to Thunderbird then since in SeaMonkey 2.1b3pre, it is still "Preview"?

Comment 8

[Wayne Mery (:wsmwk)]

I goofed :(

Comment 9

[Philip Chee]

Edmund, you seem to like simple preference bugs ;-)

Comment 10

[Edmund Wong (:ewong)]

Attachment: Changed the button's lable from "Preview" to "Listen".

Comment 11

[Ian Neal]

Comment on attachment 519302 [details] [diff] [review]
Changed the button's lable from "Preview" to "Listen".

If we are going to change it here, we should change it in the downloads pane too.
Need to update the help pages too.
r- due to need to review changes to new files.

Comment 12

[Edmund Wong (:ewong)]

Attachment: Changed the Preview Sound to "Listen To" for Mail Notification and Download Notification.

Comment 13

[Ian Neal]

Comment on attachment 519655 [details] [diff] [review]
Changed the Preview Sound to "Listen To" for Mail Notification and Download Notification.

Why the change to "Listen to"? It was fine with "Listen".
We only have "Browse" not "Browse for", so I see no reason for "Listen to"

If you're not going to do the help here, please create a bug for it instead.

r=me with that explained/fixed and some information about what is happening with the help.

Comment 14

[Edmund Wong (:ewong)]

Attachment: Changed 'Preview' to 'Listen'

Comment 15

[[e-mail]]

Comment on attachment 520374 [details] [diff] [review]
Changed 'Preview' to 'Listen'

I don't think Listen is right.

I'd be happy with Play though, with or without an icon.

Comment 16

[Edmund Wong (:ewong)]

Attachment: Changed the Preview Sound to "Play" for Mail Notification and Download Notification.

Comment 17

[Ian Neal]

Comment on attachment 521492 [details] [diff] [review]
Changed the Preview Sound to "Play" for Mail Notification and Download Notification.

Good apart from the fact you have forgotten the popup prefs and the help pages in this patch. r- so I can look at complete patch.

Comment 18

[Edmund Wong (:ewong)]

Attachment: Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification. (v5)

Comment 19

[Edmund Wong (:ewong)]

Attachment: Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification and their respective help. (v6)

Comment 20

[Ian Neal]

Comment on attachment 522205 [details] [diff] [review]
Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification and their respective help. (v6)

>+++ b/suite/common/pref/pref-popups.xul

>+        <button id="playSound"
>+                label="&playSound.label;"
>+                accesskey="&playSound.accesskey;"
>                 preference="pref.advanced.popups.disable_button.preview_sound"
>+                oncommand="PlaySound();"/>

>+++ b/suite/locales/en-US/chrome/common/pref/pref-popups.dtd

> <!ENTITY playSound.accesskey            "P">
> <!ENTITY systemSound.label              "System beep">
> <!ENTITY systemSound.accesskey          "S">
> <!ENTITY customSound.label              "Custom sound file">
> <!ENTITY customSound.accesskey          "C">
> 
> <!ENTITY selectSound.label              "Browseâ¦">
> <!ENTITY selectSound.accesskey          "o">
>+<!ENTITY playSound.label                "Play">
>+<!ENTITY playSound.accesskey            "l">

These clash with the label/accesskey for the checkbox, perhaps playSoundButton.label/accesskey

r=me with that fixed.

Comment 21

[Edmund Wong (:ewong)]

Attachment: Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]

Comment 22

[[e-mail]]

Comment on attachment 522277 [details] [diff] [review]
Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]

>+<!ENTITY playButton.label               "Play">
>+<!ENTITY playButton.accesskey           "l">
I guess we don't have much of a choice of access keys...

Comment 23

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 522277 [details] [diff] [review]
Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]

http://hg.mozilla.org/comm-central/rev/d06d41cd2ccf