The default bug view has changed. See this FAQ.

Preview sound should be "listen" or play

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Preferences
--
trivial
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: Henrik Gemal, Assigned: ewong)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 6 obsolete attachments)

(Reporter)

Description

15 years ago
In the prefs for mail sound we current have a button named "Preview". Preview a
sound. Why not label it for what it actually does. "Listen"

20020924

Comment 1

15 years ago
'Listen' is a bad choice because it changes the object of the sentence from the 
sound, to the user.

e.g., You don't 'Listen' (verb) a sound (object), you (object) listen *to* 
(verb) a sound.

Generally, action should relate directly to the object, so 'Preview' (verb) 
the 'sound' (object) works ok from that point of view.

'Play' would be an less-ambigous alternative, though.

Comment 2

15 years ago
I like 'Play'.

Comment 3

15 years ago
How about a graphic button instead? The 'play' arrow has to be one of the most
easily recognized symbols, and it would also mean one less word to translate.
Windows has this for previewing system sounds.
Product: Browser → Seamonkey
does 3 votes for play morph the bug to "play"? :)

Updated

9 years ago
Component: MailNews: Notification → MailNews: Message Display
QA Contact: stephend → search

Comment 5

9 years ago
Henrik, are you still seeing this? Shredder/Thunderbird on OS X has had a button labeled "Play button for quite a while now?
Assignee: mscott → mail
Assignee: mail → nobody
QA Contact: search → message-display
WFM per comment 5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME

Comment 7

6 years ago
Should you move this bug to Thunderbird then since in SeaMonkey 2.1b3pre, it is still "Preview"?
I goofed :(
Severity: normal → trivial
Status: RESOLVED → REOPENED
Component: MailNews: Message Display → Preferences
QA Contact: message-display → preferences
Resolution: WORKSFORME → ---
Summary: Preview should be "listen" → Preview sound should be "listen" or play

Comment 9

6 years ago
Edmund, you seem to like simple preference bugs ;-)
Status: REOPENED → NEW
(Assignee)

Updated

6 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 10

6 years ago
Created attachment 519302 [details] [diff] [review]
Changed the button's lable from "Preview" to "Listen".
Attachment #519302 - Flags: review?(iann_bugzilla)

Updated

6 years ago
OS: Windows XP → All
Hardware: x86 → All

Comment 11

6 years ago
Comment on attachment 519302 [details] [diff] [review]
Changed the button's lable from "Preview" to "Listen".

If we are going to change it here, we should change it in the downloads pane too.
Need to update the help pages too.
r- due to need to review changes to new files.
Attachment #519302 - Flags: review?(iann_bugzilla) → review-
(Assignee)

Comment 12

6 years ago
Created attachment 519655 [details] [diff] [review]
Changed the Preview Sound to "Listen To" for Mail Notification and Download Notification.
Attachment #519302 - Attachment is obsolete: true
Attachment #519655 - Flags: review?(iann_bugzilla)

Comment 13

6 years ago
Comment on attachment 519655 [details] [diff] [review]
Changed the Preview Sound to "Listen To" for Mail Notification and Download Notification.

Why the change to "Listen to"? It was fine with "Listen".
We only have "Browse" not "Browse for", so I see no reason for "Listen to"

If you're not going to do the help here, please create a bug for it instead.

r=me with that explained/fixed and some information about what is happening with the help.
Attachment #519655 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 14

6 years ago
Created attachment 520374 [details] [diff] [review]
Changed 'Preview' to 'Listen'
Attachment #519655 - Attachment is obsolete: true
Attachment #520374 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #520374 - Flags: review? → review?(iann_bugzilla)

Updated

6 years ago
Attachment #520374 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Updated

6 years ago
Attachment #520374 - Flags: ui-review?(neil)
Comment on attachment 520374 [details] [diff] [review]
Changed 'Preview' to 'Listen'

I don't think Listen is right.

I'd be happy with Play though, with or without an icon.
Attachment #520374 - Flags: ui-review?(neil) → ui-review-
(Assignee)

Comment 16

6 years ago
Created attachment 521492 [details] [diff] [review]
Changed the Preview Sound to "Play" for Mail Notification and Download Notification.
Attachment #520374 - Attachment is obsolete: true
Attachment #521492 - Flags: review?(iann_bugzilla)

Comment 17

6 years ago
Comment on attachment 521492 [details] [diff] [review]
Changed the Preview Sound to "Play" for Mail Notification and Download Notification.

Good apart from the fact you have forgotten the popup prefs and the help pages in this patch. r- so I can look at complete patch.
Attachment #521492 - Flags: review?(iann_bugzilla) → review-
(Assignee)

Comment 18

6 years ago
Created attachment 522203 [details] [diff] [review]
Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification. (v5)
Attachment #521492 - Attachment is obsolete: true
Attachment #522203 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 19

6 years ago
Created attachment 522205 [details] [diff] [review]
Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification and their respective help. (v6)
Attachment #522203 - Attachment is obsolete: true
Attachment #522205 - Flags: review?(iann_bugzilla)
Attachment #522203 - Flags: review?(iann_bugzilla)

Comment 20

6 years ago
Comment on attachment 522205 [details] [diff] [review]
Changed the Preview Sound to "Play" for Popups, Mail Notification and Download Notification and their respective help. (v6)

>+++ b/suite/common/pref/pref-popups.xul

>+        <button id="playSound"
>+                label="&playSound.label;"
>+                accesskey="&playSound.accesskey;"
>                 preference="pref.advanced.popups.disable_button.preview_sound"
>+                oncommand="PlaySound();"/>

>+++ b/suite/locales/en-US/chrome/common/pref/pref-popups.dtd

> <!ENTITY playSound.accesskey            "P">
> <!ENTITY systemSound.label              "System beep">
> <!ENTITY systemSound.accesskey          "S">
> <!ENTITY customSound.label              "Custom sound file">
> <!ENTITY customSound.accesskey          "C">
> 
> <!ENTITY selectSound.label              "Browse…">
> <!ENTITY selectSound.accesskey          "o">
>+<!ENTITY playSound.label                "Play">
>+<!ENTITY playSound.accesskey            "l">

These clash with the label/accesskey for the checkbox, perhaps playSoundButton.label/accesskey

r=me with that fixed.
Attachment #522205 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 21

6 years ago
Created attachment 522277 [details] [diff] [review]
Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]
(Assignee)

Updated

6 years ago
Attachment #522277 - Flags: ui-review?(neil)
Attachment #522277 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #522205 - Attachment is obsolete: true
Comment on attachment 522277 [details] [diff] [review]
Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]

>+<!ENTITY playButton.label               "Play">
>+<!ENTITY playButton.accesskey           "l">
I guess we don't have much of a choice of access keys...
Attachment #522277 - Flags: ui-review?(neil) → ui-review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Comment on attachment 522277 [details] [diff] [review]
Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]

http://hg.mozilla.org/comm-central/rev/d06d41cd2ccf
Attachment #522277 - Attachment description: Changed 'Preview buton' to "Play" button. (v7) → Changed 'Preview buton' to "Play" button. (v7) [Checkin: comment 23]
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.