[DevTools Release 90 Tasks] Remove outdated watcher traits
Categories
(DevTools :: Framework, task, P3)
Tracking
(firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
We have two watcher actor traits that can be removed in 90 cycle + others already outdated: https://searchfox.org/mozilla-central/rev/185ab5e4f4e01341e009cd4633d1275ffe4d4c8b/devtools/server/actors/watcher.js#165-185
|
||
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
Assignee | |
Comment 2•3 years ago
|
||
The rest of the patches in this stack will remove WatcherActor traits.
But the call sites should still check that the watcher is available.
Making the argument optional allows to reuse the same method as we remove the traits.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D114216
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D114217
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D114218
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D114219
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd1897d8f4f7 [devtools] Make type optional in TargetCommand::hasTargetWatcherSupport r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/01c734cf932b [devtools] Remove set-breakpoints watcher trait r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/4b050529f294 [devtools] Remove target-configuration watcher trait r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/8a076c8a6809 [devtools] Remove thread-configuration watcher trait r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/93e7d2403509 [devtools] Remove set-xhr-breakpoints watcher trait r=nchevobbe
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dd1897d8f4f7
https://hg.mozilla.org/mozilla-central/rev/01c734cf932b
https://hg.mozilla.org/mozilla-central/rev/4b050529f294
https://hg.mozilla.org/mozilla-central/rev/8a076c8a6809
https://hg.mozilla.org/mozilla-central/rev/93e7d2403509
Description
•