1709274 - Update wrench-macos-build to clang-12

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Andi [:andi]]

Attachment: Bug 1709274 - Update wrench-macos-build to clang-12.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Toolchains' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b000faa025
Update wrench-macos-build to clang-12. r=glandium

Comment 4

[Iulian Moraru]

Backed out for causing Build Bustages.

Push with failures

Failure log

Backout link

Comment 5

[Andi [:andi]]

For the moment I don't think we can move with this further. We use omesa and gallium references [1] LLVMAddConstantPropagationPass. But this function has been removed[2] from LLVM.
The simpler choice would be to patch out this feature from our LLVM toolchain, but for the long term I don't think it's the way to go. We should update the library.

[1] https://github.com/servo/osmesa-src/blob/master/mesa-src/src/gallium/auxiliary/gallivm/lp_bld_init.c/#L172
[2] https://reviews.llvm.org/D85159

Comment 6

[Dzmitry Malyshau [:kvark]]

What is the NI for? If you think we should update osmesa in order to unblock this change, I'm all for it :)

Comment 7

[Andi [:andi]]

Attachment: Bug 1709274 - This is a test

Comment 8

[Andi [:andi]]

(In reply to Dzmitry Malyshau [:kvark] from comment #6)

What is the NI for? If you think we should update osmesa in order to unblock this change, I'm all for it :)

could you help with this since this is beyond my area of expertise?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:andi, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Mike Hommey [:glandium]]

AFAICT, there is no newer version of osmesa that supports llvm 12.

Comment 11

[Andi [:andi]]

Let's keep this issue as tracking the evolution of osmesa and when patch for llvm 12 appears we will update it.

Comment 12

[Dzmitry Malyshau [:kvark]]

Removing NI since it's not actionable right now

Comment 13

[Mike Hommey [:glandium]]

Actually, this has been fixed for a while in upstream mesa:
https://gitlab.freedesktop.org/mesa/mesa/-/commit/52cac068621a5998f486f8e44f9c2d9d045d1c31
https://gitlab.freedesktop.org/mesa/mesa/-/commit/1d018bc7fde744b5fc71108887a51e5bfaff8776

Comment 14

[Mike Hommey [:glandium]]

Submitted https://github.com/servo/osmesa-src/pull/46

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1709274 - Upgrade osmesa-src to current trunk.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb289b92c4e
Upgrade osmesa-src to current trunk. r=gfx-reviewers,jrmuizel
https://hg.mozilla.org/integration/autoland/rev/78f7d1c667d8
Update wrench-macos-build to clang-12. r=glandium

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0bb289b92c4e
https://hg.mozilla.org/mozilla-central/rev/78f7d1c667d8

Comment 18

[Dzmitry Malyshau [:kvark]]

glandium got this (thank you!)