Closed
Bug 1709277
Opened 4 years ago
Closed 4 years ago
Simplify the OOMAllocationSize crash annotation
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
We can simplify how we record OOMAllocationSize like :glandium suggested in D114009:
wouldn't it be simpler to have a single field, in mozglue, exported as MFBT_DATA? no need for a wrapper function to get the value, no need for a separate value in libxul, and not need to check two places.
Let's wait to confirm that bug 1683288 fixes our missing annotations and then we can clean this up.
(also this might be a good-first-bug given it's a mechanical change)
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → lissyx+mozillians
Attachment #9222355 -
Attachment description: WIP: Bug 1709277 - Simplify gOOMAllocationSize via MFBT_DATA → Bug 1709277 - Simplify gOOMAllocationSize via MFBT_DATA r?glandium
Status: NEW → ASSIGNED
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff52343b2e52
Simplify gOOMAllocationSize via MFBT_DATA r=glandium
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•