1709283 - 60.86 - 2.86% perf_reftest bidi-resolution-1.html / displaylist_mutate + 96 more (Linux, OSX, Windows) regression on Wed April 28 2021

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push 3318f20119353cdf15a1132259fc0644e83989f6. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
61%	perf_reftest (docs)	bidi-resolution-1.html	linux1804-64-shippable-qr	e10s stylo webrender	15.83 -> 25.46
52%	perf_reftest (docs)	bidi-resolution-1.html	linux1804-64-shippable-qr	e10s stylo webrender	16.52 -> 25.10
45%	perf_reftest (docs)	some-descendants-1.html	windows10-64-shippable-qr	e10s stylo webrender	4.64 -> 6.71
43%	perf_reftest (docs)	some-descendants-1.html	linux1804-64-shippable-qr	e10s stylo webrender	4.42 -> 6.29
40%	perf_reftest (docs)	some-descendants-1.html	windows10-64-shippable	e10s stylo	5.12 -> 7.14
37%	perf_reftest (docs)	some-descendants-1.html	windows10-64-shippable-qr	e10s stylo webrender-sw	4.72 -> 6.48
37%	perf_reftest (docs)	some-descendants-1.html	linux1804-64-shippable	e10s stylo	5.10 -> 6.98
30%	perf_reftest_singletons (docs)	tiny-traversal-singleton.html	macosx1100-64-shippable-qr	e10s stylo webrender	512.63 -> 666.84
29%	perf_reftest (docs)	some-descendants-1.html	linux1804-64-shippable-qr	e10s stylo webrender-sw	5.05 -> 6.51
26%	perf_reftest_singletons (docs)	tiny-traversal-singleton.html	linux1804-64-shippable	e10s stylo	794.36 -> 1,004.38
...	...	...	...	...	...
6%	perf_reftest_singletons (docs)	abspos-reflow-1.html	macosx1100-64-shippable-qr	e10s stylo webrender	40.91 -> 43.45
6%	perf_reftest_singletons (docs)	scrollbar-styles-1.html	linux1804-64-shippable	e10s stylo	392.82 -> 416.72
4%	tresize (docs)		macosx1015-64-shippable-qr	e10s stylo webrender	6.85 -> 7.13
3%	tart (docs)		macosx1015-64-shippable-qr	e10s stylo webrender-sw	2.09 -> 2.15
3%	displaylist_mutate (docs)		macosx1015-64-shippable-qr	e10s stylo webrender-sw	2,242.45 -> 2,306.57

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
11%	perf_reftest_singletons (docs)	style-attr-1.html	macosx1100-64-shippable-qr	e10s stylo webrender	2.89 -> 2.57
9%	perf_reftest_singletons (docs)	id-getter-1.html	windows10-64-shippable-qr	e10s stylo webrender	441.19 -> 399.59
7%	perf_reftest_singletons (docs)	bidi-resolution-1.html	linux1804-64-shippable	e10s stylo	327.69 -> 305.05
5%	perf_reftest_singletons (docs)	bidi-resolution-1.html	linux1804-64-shippable-qr	e10s stylo webrender	346.71 -> 328.48

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

One of the 3 bugs from regressed by field caused this regression, but I'm not sure which one. :andy or :glandium, can you please help on this?

Comment 2

[Mike Hommey [:glandium]]

Most certainly bug 1697215

Comment 3

[Mike Hommey [:glandium]]

There's going to be an update of rust this week (bug 1708379), which would align the LLVM versions, and might alleviate those regressions, let's wait for that.

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #29876 (as of Thu, 29 Apr 2021 08:41:11 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
0.18%	installer size		osx-shippable	instrumented	114,927,937.92 -> 115,129,774.67
0.16%	installer size		osx-shippable	instrumented	114,927,750.46 -> 115,112,888.75

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	build times		linux64-shippable	nightly taskcluster-m5.4xlarge	2,592.85 -> 2,486.76

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29876

Comment 5

[Florin Strugariu [:Bebe]]

== Change summary for alert #29947 (as of Tue, 04 May 2021 04:36:31 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
7%	google-docs	fcp	windows10-64-shippable-qr	warm webrender	216.17 -> 231.67
6%	google-docs	fnbpaint	windows10-64-shippable-qr	warm webrender	219.60 -> 233.75
6%	google-docs	fnbpaint	windows10-64-shippable-qr	warm webrender	221.04 -> 234.50

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
10%	amazon-search	fnbpaint	android-hw-g5-7-0-arm7-api-16-shippable	warm	788.31 -> 709.50

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29947

Comment 6

[Julien Cristau [:jcristau]]

Bug 1708379 has landed, do we know if anything remains?

Comment 7

[Florin Strugariu [:Bebe]]

(In reply to Julien Cristau [:jcristau] from comment #6)

Bug 1708379 has landed, do we know if anything remains?

we have this alert so all looks good!
https://treeherder.mozilla.org/perfherder/alerts?id=30012