1709316 - Replace the frameloader after marking the BC as not being in BFCache anymore

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Comment 1

[Peter Van der Beken [:peterv]]

The way we do it currently causes us to change focus (as a result of the nsFrameLoaderOwner::ReplaceFrameLoader call) before we marked the BC as not in BFCache. nsFocusManager::IsWindowVisible is false for windows that are in BFCache (they're frozen), and so we set the focus but don't fire any events. When we then mark the BC as 'not in BFCache' we never end up firing the focus event. Postponing the nsFrameLoaderOwner::ReplaceFrameLoader call until after we mark the BC as 'not in BFCache' seems to fix this.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1709316 - Replace the frameloader after marking the BC as not being in BFCache anymore. r?nika!

nsFrameLoaderOwner::ReplaceFrameLoader calls nsFocusManager::ActivateRemoteFrameIfNeeded.
If the call to nsFrameLoaderOwner::ReplaceFrameLoader happens before the BC is marked as
not in BFCache, then the focus manager will not fire focus events because the window is
still frozen.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ee59915b77a
Replace the frameloader after marking the BC as not being in BFCache anymore. r=nika

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6ee59915b77a