Closed Bug 1709349 Opened 3 years ago Closed 3 years ago

[macOS] Checked checkboxes in High Contrast mode should still be blue / use accent colour

Categories

(Toolkit :: Themes, defect, P3)

Product:
Toolkit
Component:
Themes
Platform:
Desktop
macOS
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox88 --- disabled
firefox89 --- wontfix
firefox90 --- wontfix
firefox96 --- verified
firefox97 --- verified

People

(Reporter: rdoghi, Assigned: lamoure6)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [proton-modals])

Attachments

(3 files)

Screenshot 2021-05-04 at 14.52.33.png
17.80 KB, image/png
Details
checkmark.mp4
2.41 MB, video/mp4
Details
Bug 1709349 - Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley
48 bytes, text/x-phabricator-request
Details | Review

[Affected platforms]:
Platforms: MAC OSX 11

[Preconditions]:

Reach about:config and set browser.proton.enabled = true
Have High Contrast Enabled on MAC os

[Steps to reproduce]:

  1. Launch the Firefox browser and open a few tabs
  2. Close the Firefox browser and trigger the Close multiple tabs modal.
  3. Mark the Checkbox from the modal.

Expected Result:
The Checkbox marked state should be blue.

Actual Results:
The checkbox Marked state is grey when High contrast is enabled on mac

Has Regression Range: --- → no
Has STR: --- → yes
status-firefox88: --- → disabled
status-firefox89: --- → affected
Blocks: proton-modals, 1694132
Summary: Wrong color displayed on a Marked checkbox on a modal when High Contrast mode is enabled → [macOS] Checked checkboxes in High Contrast mode should still be blue / use accent colour
See Also: → https://jira.mozilla.com/browse/FIDEFE-1632
Whiteboard: [proton-modals]
Priority: -- → P3
Assignee: nobody → lamoure6
Status: NEW → ASSIGNED

I'm unable to see this on my macbook on Nightly 95. Are you still able to see this issue?

Flags: needinfo?(rares.doghi)

Yes this issue still occurs, I will attach a screen recording of this issue.

Flags: needinfo?(rares.doghi)
Attached video checkmark.mp4 —
Points: --- → 1
Attachment #9248972 - Attachment description: WIP: Bug 1709349 - Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley → Bug 1709349 - Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da5ac73d26ff
Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/da5ac73d26ff

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Flags: qe-verify+

This issue is Verified as fixed in our latest build 97.0a1 (2021-12-10) as well as in our latest Beta 96.0b3.

Status: RESOLVED → VERIFIED
status-firefox96: fixed → verified
status-firefox97: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: